Facility mapper

[ashish-egov]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new CSS class for dropdown styling, enhancing layout options.
  • Updated FacilityPopup component with improved data management and a tabbed interface for better navigation between assigned and unassigned facilities.
  • Added new hooks for managing employee and census searches, streamlining data fetching processes.

• Bug Fixes

  • Enhanced error handling for census data fetching to provide clearer feedback.

• Documentation

  • Updated documentation to reflect new hooks and component functionalities.

[coderabbitai]

Caution

Review failed

The head commit changed during the review from a1ce3e0 to 2afc1a9.

📝 Walkthrough

📝 Walkthrough

📝 Walkthrough

Walkthrough

This pull request introduces several changes across multiple components in the microplan module. A new CSS class for dropdown styling is added, enhancing layout options. The FacilityPopup component undergoes significant updates, including new state management, tab functionality, and data fetching hooks. The SearchJurisdiction component sees a minor structural change with a new wrapper for dropdowns. Additionally, two new custom hooks for census searching and a new asynchronous function for fetching census data are introduced, improving data handling capabilities.

Changes

File	Change Summary
.../microplan.scss	Added new CSS class .digit-multiselectdropdown-wrap.nestedmultiselect with width: 100%;.
.../FacilityPopup.js	Updated component with new imports, state management, tab handling, data fetching, and rendering logic.
.../SearchJurisdiction.js	Added a wrapper <div> around MultiSelectDropdown styled with width: 100%;.
.../index.js	Added hooks usePlanSearchEmployee and useCensusSearch to exports.
.../services/censusSearchConfig.js	Introduced censusSearchConfig function for fetching census data with error handling.
.../useCensusSearch.js	Introduced custom hook useCensusSearch for managing census data fetching with react-query.

Possibly related PRs

• Sandbox UI fixes #1442: The changes in sandbox.scss include the addition of a wrapper styled with a width of "100%", which relates to the new CSS class .digit-multiselectdropdown-wrap.nestedmultiselect added in the main PR, as both involve styling adjustments for layout consistency.
• added new hook for microplans search screen #1587: The introduction of the new hook useSavedMicroplansWithCampaign in the microplan module may relate to the overall enhancements in user interface components, including dropdowns and filters, as seen in the main PR's focus on expanding styling options for UI elements.

Suggested reviewers

• nipunarora-eGov

🐰 In the garden of code, we hop and play,
New classes and hooks brighten the way.
With dropdowns that stretch, and popups that gleam,
Our microplan's better, like a sweet dream!
So let’s celebrate this code-filled delight,
For every small change makes our UI just right! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 12

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (1)

Line range hint 71-86: Approved with a suggestion for improvement

The addition of the wrapper <div> with width: 100% is a good improvement for layout consistency. It ensures that the MultiSelectDropdown component takes up the full width of its container, which aligns with the intended UI design.

However, to improve maintainability, consider moving the inline style to a CSS class. This would make it easier to manage styles across the application and adhere to the principle of separation of concerns.

Consider refactoring the inline style to a CSS class:

1. In your CSS file (e.g., microplan.scss), add:

.full-width-dropdown-wrapper {
  width: 100%;
}

2. Then, update the JSX:

- <div style={{ width: "100%" }}>
+ <div className="full-width-dropdown-wrapper">

This change will improve code maintainability while preserving the intended layout.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 37b265c and f685550.

📒 Files selected for processing (6)

• health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplan.scss (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/index.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/censusSearchConfig.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useCensusSearch.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/index.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/censusSearchConfig.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useCensusSearch.js (1)

Pattern **/*.js: check

🪛 Biome

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js

[error] 270-270: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)

---

[error] 271-271: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

---

[error] 338-345: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useCensusSearch.js (1)

1-7: LGTM! Well-structured custom hook implementation.

The useCensusSearch hook is well-implemented using react-query's useQuery. The structure is clean and follows good practices for custom hook creation.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/index.js (1)

12-13: LGTM: New hooks imported correctly.

The new imports for usePlanSearchEmployee and useCensusSearch are added correctly, following the existing import pattern and naming conventions.