Feature/er

[suryansh-egov]

Choose the appropriate template for your PR:

• Feature PR
• Bugfix PR
• Release PR

Summary by CodeRabbit

• New Features

  • Enhanced logic for processing dose criteria, improving campaign data evaluation.
  • Improved data structuring for boundary type data in campaign management.
  • Refined mapping of product variants and condition parsing for delivery rules.

• Bug Fixes

  • Corrected handling of the "IN_BETWEEN" operator for better condition processing.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request primarily involve updates to the setupCampaignHelpers.js file, enhancing various utility functions related to campaign data processing. Key modifications include adjustments to the processDoseCriteria, groupByTypeRemap, and reverseDeliveryRemap functions, focusing on how attributes are defined, ensuring proper initialization of result structures, and refining the handling of conditions for delivery rules. These changes aim to improve the clarity and correctness of data handling within the campaign setup utilities.

Changes

File	Change Summary
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/setupCampaignHelpers.js	- Updated processDoseCriteria to change attribute code from "structure" to "TYPE_OF_STRUCTURE" based on projectType. - Modified groupByTypeRemap to correctly initialize the result object and check for existing types before pushing items. - Enhanced reverseDeliveryRemap for better mapping of product variants and refined logic for the "IN_BETWEEN" operator.

Possibly related PRs

• fixed summary and campaign creation #1479: Modifications to the reverseDeliveryRemap function in CampaignSummary.js and DeliveryDetailsSummary.js, related to delivery data processing.
• project type config simplified #1539: Changes in reverseDeliveryRemap function in CampaignSummary.js, directly connected to handling delivery data.
• fixed validation cond for app #1891: Updates to processDelivery and processDoseCriteria functions in setupCampaignHelpers.js, related to delivery rules and dose criteria processing.
• changes in the delivery type and selection of boundary #1816: Changes in setupCampaignHelpers.js regarding the processDelivery function, aligning with improvements in data handling logic.

Suggested reviewers

• jagankumar-egov

🐰 In the meadow, where the data flows,
Campaigns bloom, as the logic grows.
With types and structures, we refine the way,
Hopping through rules, brightening the day!
So let’s celebrate with a joyful cheer,
For clearer paths, the bunnies hold dear! 🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 98aa7ba and dfb83d2.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/setupCampaignHelpers.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/setupCampaignHelpers.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/setupCampaignHelpers.js (1)

193-193: Verify impact of attribute code change for IRS-mz projects

The change from "structure" to "TYPE_OF_STRUCTURE" appears to be a standardization of attribute naming. While the change itself is logical, we should ensure compatibility with existing data and system components.

Let's verify the usage of this attribute code across the codebase:

✅ Verification successful

Attribute code change is consistently implemented across the codebase

The verification shows that:

• The new "TYPE_OF_STRUCTURE" attribute code is consistently used across all relevant files in the campaign manager module
• It's properly configured in deliveryConfig.js
• The UI components in AddDeliverycontext.js handle it correctly
• No instances of the old "structure" attribute code were found
• All IRS-mz project type handling consistently uses this attribute

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for references to both old and new attribute codes
# to ensure all occurrences are updated consistently

echo "Searching for references to 'structure' attribute..."
rg -i "\"structure\"" --type js

echo "Searching for references to 'TYPE_OF_STRUCTURE' attribute..."
rg "TYPE_OF_STRUCTURE" --type js

echo "Searching for IRS-mz project type handling..."
rg "IRS-mz" --type js

Length of output: 2833

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.