Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Remove command improvements #224

Merged
merged 4 commits into from
Jan 12, 2024
Merged

CLI Remove command improvements #224

merged 4 commits into from
Jan 12, 2024

Conversation

daniel-milchev
Copy link
Contributor

[#217] CLI Remove command improvements

  • Timeout was added to the remove command.
  • Timeout was changed in the stop command.
  • Changed default container stop timeout to duration string.

Signed-off-by: Daniel Milchev [email protected]

@daniel-milchev
[eclipse-kanto#217] Timeout was added to the remove command. Timeout …
53f091f 
…was changed in the stop command. Changed default container stop timeout to duration string.
dimitar-dimitrow
dimitar-dimitrow suggested changes Jan 9, 2024
View reviewed changes
containerm/mgr/mgr_opts.go Outdated Show resolved Hide resolved
containerm/services/grpc_services_test.go Show resolved Hide resolved
containerm/daemon/daemon_config_util.go Outdated Show resolved Hide resolved
containerm/ctr/ctrd_client_test.go Outdated Show resolved Hide resolved
dimitar-dimitrow
dimitar-dimitrow suggested changes Jan 11, 2024
View reviewed changes
containerm/cli/cli_command_ctrs_stop.go Outdated Show resolved Hide resolved
containerm/cli/cli_command_ctrs_remove.go Outdated Show resolved Hide resolved
@dimitar-dimitrow dimitar-dimitrow removed the request for review from k-gostev January 12, 2024 13:05
@dimitar-dimitrow dimitar-dimitrow merged commit 1cad3aa into eclipse-kanto:dev-m5 Jan 12, 2024
2 checks passed
@dimitar-dimitrow dimitar-dimitrow deleted the remove-improvements branch January 12, 2024 13:08
@dimitar-dimitrow dimitar-dimitrow linked an issue Jan 12, 2024 that may be closed by this pull request
CLI Remove command improvements #217
Closed
k-gostev pushed a commit that referenced this pull request Apr 30, 2024
@daniel-milchev @k-gostev
CLI Remove command improvements (#224)
f4ee3c6 
[#217] CLI Remove command improvements
 - Timeout was added to the remove command
 - Timeout was changed in the stop command
 - Changed default container stop timeout to duration string

Signed-off-by: Daniel Milchev [email protected]
k-gostev pushed a commit that referenced this pull request Apr 30, 2024
@daniel-milchev @k-gostev
CLI Remove command improvements (#224)
c23808e 
[#217] CLI Remove command improvements
 - Timeout was added to the remove command
 - Timeout was changed in the stop command
 - Changed default container stop timeout to duration string

Signed-off-by: Daniel Milchev [email protected]
k-gostev pushed a commit that referenced this pull request Apr 30, 2024
@daniel-milchev @k-gostev
CLI Remove command improvements (#224)
b6aa163 
[#217] CLI Remove command improvements
 - Timeout was added to the remove command
 - Timeout was changed in the stop command
 - Changed default container stop timeout to duration string

Signed-off-by: Daniel Milchev [email protected]
k-gostev pushed a commit that referenced this pull request May 9, 2024
@daniel-milchev @k-gostev
CLI Remove command improvements (#224)
721b71b 
[#217] CLI Remove command improvements
 - Timeout was added to the remove command
 - Timeout was changed in the stop command
 - Changed default container stop timeout to duration string

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Kristiyan Gostev <[email protected]>
k-gostev pushed a commit that referenced this pull request May 10, 2024
@daniel-milchev @k-gostev
CLI Remove command improvements (#224)
731b916 
[#217] CLI Remove command improvements
 - Timeout was added to the remove command
 - Timeout was changed in the stop command
 - Changed default container stop timeout to duration string

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Kristiyan Gostev <[email protected]>
dimitar-dimitrow added a commit that referenced this pull request May 10, 2024
@k-gostev @daniel-milchev
@stoyan-zoubev @dimitar-dimitrow
Merge dev-m5 into main (#235)
a951f1c 
[#234] Merge `dev-m5` branch into `main`
* [#51] Improve containerd client unit tests (#203)
* [#201] Optimized, deterministic intermediate desired state feedback messages (#204)
* [#208] Add file flag to the CLI create command (#209)
* [#191] Container remains Stopped after container-management service restart (#214)
* [#210] Remove command should accept more than one container ID (#212)
* [#196] Starting of constantly restarting container fails (#216)
* [#67] Implement signed images verification (#215)
* [#91] Provide unit tests covering signed images verification (#220)
* [#213] Add quiet flag, to the list command. (#221)
* [#217] CLI Remove command improvements (#224)

---------

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Stoyan Zoubev <[email protected]>
Signed-off-by: Kristiyan Gostev <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Daniel Milchev <[email protected]>
Co-authored-by: Stoyan Zoubev <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-gostev k-gostev k-gostev left review comments

@dimitar-dimitrow dimitar-dimitrow dimitar-dimitrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI Remove command improvements
3 participants
@daniel-milchev @dimitar-dimitrow @k-gostev