Add file flag to the CLI create command #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitar-dimitrow
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
As currently implemented one can use the file flag in combination with other flags.
- If the same property(e.g. privileged) is defined through both it's flag and in the file, the property from the file is applied.
- If the property is defined only through it's flag and is missing in the file, then the flag gets applied.
This behavior is not intuitive, as usually flags have the highest priority. Applying the file as a base and then merging the configuration applied through flags is not straightforward and is prone to errors. As discussed with @k-gostev the best option is to forbid applying other flags whenfileis used.
Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow
approved these changes
Nov 16, 2023
k-gostev
approved these changes
Nov 16, 2023
dimitar-dimitrow
added a commit
that referenced
this pull request
May 10, 2024
[#234] Merge `dev-m5` branch into `main` * [#51] Improve containerd client unit tests (#203) * [#201] Optimized, deterministic intermediate desired state feedback messages (#204) * [#208] Add file flag to the CLI create command (#209) * [#191] Container remains Stopped after container-management service restart (#214) * [#210] Remove command should accept more than one container ID (#212) * [#196] Starting of constantly restarting container fails (#216) * [#67] Implement signed images verification (#215) * [#91] Provide unit tests covering signed images verification (#220) * [#213] Add quiet flag, to the list command. (#221) * [#217] CLI Remove command improvements (#224) --------- Signed-off-by: Daniel Milchev [email protected] Signed-off-by: Stoyan Zoubev <[email protected]> Signed-off-by: Kristiyan Gostev <[email protected]> Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Daniel Milchev <[email protected]> Co-authored-by: Stoyan Zoubev <[email protected]> Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#208] Added the file flag. Added unit and integration tests for it.
Signed-off-by: Daniel Milchev [email protected]