Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting of constantly restarting container fails #196

Closed
dimitar-dimitrow opened this issue Aug 31, 2023 · 0 comments · Fixed by #216
Closed

Starting of constantly restarting container fails #196

dimitar-dimitrow opened this issue Aug 31, 2023 · 0 comments · Fixed by #216
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dimitar-dimitrow
Copy link
Contributor

When a constantly restarting container update is received from the Update Manager, the Container's Update Agent, tries to start the container. However, there seems to be a concurrency problem, between the UA and the auto restart mechanism. The update activity finishes with status INCOMPLETE and the following error is logged:

time="2023-08-31T09:28:17.50888366Z" level=error msg="[container-management][ctrd_client.go:255][pkg:github][func:com/eclipse-kanto/container-management/containerm/ctr] error creating task for container ID = cd0be8fb-e533-4cce-bbc4-f0db9d0775d8 \n\t Error: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: time=\"2023-08-31T09:28:17Z\" level=fatal msg=\"no sandbox present for cd0be8fb-e533-4cce-bbc4-f0db9d0775d8\": unknown " time="2023-08-31T09:28:17.525847659Z" level=error msg="[container-management][update_operation.go:546][pkg:github][func:com/eclipse-kanto/container-management/containerm/updateagent] could not start container [hello-world] \n\t Error: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: time=\"2023-08-31T09:28:17Z\" level=fatal msg=\"no sandbox present for cd0be8fb-e533-4cce-bbc4-f0db9d0775d8\": unknown "

@dimitar-dimitrow dimitar-dimitrow added the bug Something isn't working label Aug 31, 2023
@k-gostev k-gostev added this to the M5 milestone Sep 4, 2023
@k-gostev k-gostev moved this to Todo in Eclipse Kanto Sep 4, 2023
@dimitar-dimitrow dimitar-dimitrow moved this from Todo to In Progress (max 10) in Eclipse Kanto Nov 22, 2023
dimitar-dimitrow added a commit to bosch-io/container-management that referenced this issue Nov 23, 2023
 - Do not release container resources when restart manager is canceled, they are already released upon exit.
 - Apply restart policy when it is updated.

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitar-dimitrow dimitar-dimitrow moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Nov 23, 2023
@dimitar-dimitrow dimitar-dimitrow linked a pull request Nov 23, 2023 that will close this issue
k-gostev pushed a commit that referenced this issue Nov 23, 2023
- Do not release container resources when restart manager is canceled, they are already released upon exit.
 - Apply restart policy when it is updated.

Signed-off-by: Dimitar Dimitrov <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready for Review (max 3) to Done in Eclipse Kanto Nov 24, 2023
k-gostev pushed a commit that referenced this issue Apr 30, 2024
- Do not release container resources when restart manager is canceled, they are already released upon exit.
 - Apply restart policy when it is updated.

Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitar-dimitrow added a commit that referenced this issue May 10, 2024
[#234] Merge `dev-m5` branch into `main`
* [#51] Improve containerd client unit tests (#203)
* [#201] Optimized, deterministic intermediate desired state feedback messages (#204)
* [#208] Add file flag to the CLI create command (#209)
* [#191] Container remains Stopped after container-management service restart (#214)
* [#210] Remove command should accept more than one container ID (#212)
* [#196] Starting of constantly restarting container fails (#216)
* [#67] Implement signed images verification (#215)
* [#91] Provide unit tests covering signed images verification (#220)
* [#213] Add quiet flag, to the list command. (#221)
* [#217] CLI Remove command improvements (#224)

---------

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Stoyan Zoubev <[email protected]>
Signed-off-by: Kristiyan Gostev <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Daniel Milchev <[email protected]>
Co-authored-by: Stoyan Zoubev <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants