Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve containerd client unit tests #51

Closed
konstantina-gramatova opened this issue Sep 16, 2022 · 0 comments · Fixed by #203
Closed

Improve containerd client unit tests #51

konstantina-gramatova opened this issue Sep 16, 2022 · 0 comments · Fixed by #203
Assignees
@daniel-milchev
Labels
task Single unit of work
Milestone
M5

Comments

@konstantina-gramatova
Copy link
Contributor

Ensure the currently uncovered logic in the containerd client implementation is properly handled - e.g. DestroyContainer()
@konstantina-gramatova konstantina-gramatova added the task Single unit of work label Sep 16, 2022
@konstantina-gramatova konstantina-gramatova added this to the M3 milestone Sep 30, 2022
@k-gostev k-gostev removed this from the M3 milestone May 30, 2023
@k-gostev k-gostev added this to the M5 milestone Sep 4, 2023
@daniel-milchev daniel-milchev self-assigned this Sep 14, 2023
@daniel-milchev daniel-milchev moved this from Todo to In Progress (max 10) in Eclipse Kanto Sep 14, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 19, 2023
@daniel-milchev
[eclipse-kanto#51] Imporved unit tests.
e28f185 
Signed-off-by: Daniel Milchev [email protected]
@daniel-milchev daniel-milchev mentioned this issue Oct 19, 2023
Merged
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 19, 2023
@daniel-milchev
[eclipse-kanto#51] Fixed formatting.
bc20e96 
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 19, 2023
@daniel-milchev
[eclipse-kanto#51] Fixed formatting.
1c029ff 
Signed-off-by: Daniel Milchev [email protected]
@dimitar-dimitrow dimitar-dimitrow linked a pull request Oct 19, 2023 that will close this issue
Improve containerd client unit tests #203
Merged
@dimitar-dimitrow dimitar-dimitrow moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Oct 20, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 23, 2023
@daniel-milchev
[eclipse-kanto#51] Removed the uneeded files.
8a5786c 
Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow pushed a commit to bosch-io/container-management that referenced this issue Oct 23, 2023
@daniel-milchev @dimitar-dimitrow
[eclipse-kanto#51] Imporved unit tests.
78198cb 
Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow pushed a commit to bosch-io/container-management that referenced this issue Oct 23, 2023
@daniel-milchev @dimitar-dimitrow
[eclipse-kanto#51] Fixed formatting.
9186b20 
Signed-off-by: Daniel Milchev [email protected]
@k-gostev k-gostev moved this from Ready for Review (max 3) to Done in Eclipse Kanto Oct 25, 2023
@k-gostev k-gostev moved this from Done to In Review (max 3) in Eclipse Kanto Oct 25, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 25, 2023
@daniel-milchev
[eclipse-kanto#51] Imporved unit tests.
a8da8c1 
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 25, 2023
@daniel-milchev
[eclipse-kanto#51] Fixed formatting.
624d958 
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 25, 2023
@daniel-milchev
[eclipse-kanto#51] Changed according to the comments.
436ae94 
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Oct 25, 2023
@daniel-milchev
[eclipse-kanto#51] Fixed according to the comments.
390e05c 
Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow pushed a commit that referenced this issue Oct 26, 2023
@daniel-milchev
Improve containerd client unit tests (#203)
9c45fef 
[#51] Improve containerd client unit tests

Signed-off-by: Daniel Milchev [email protected]
@github-project-automation github-project-automation bot moved this from In Review (max 3) to Done in Eclipse Kanto Oct 27, 2023
k-gostev pushed a commit that referenced this issue Nov 2, 2023
@daniel-milchev @k-gostev
Improve containerd client unit tests (#203)
da2b0a8 
[#51] Improve containerd client unit tests

Signed-off-by: Daniel Milchev [email protected]
k-gostev pushed a commit that referenced this issue Apr 30, 2024
@daniel-milchev @k-gostev
Improve containerd client unit tests (#203)
7923854 
[#51] Improve containerd client unit tests

Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow added a commit that referenced this issue May 10, 2024
@k-gostev @daniel-milchev
@stoyan-zoubev @dimitar-dimitrow
Merge dev-m5 into main (#235)
a951f1c 
[#234] Merge `dev-m5` branch into `main`
* [#51] Improve containerd client unit tests (#203)
* [#201] Optimized, deterministic intermediate desired state feedback messages (#204)
* [#208] Add file flag to the CLI create command (#209)
* [#191] Container remains Stopped after container-management service restart (#214)
* [#210] Remove command should accept more than one container ID (#212)
* [#196] Starting of constantly restarting container fails (#216)
* [#67] Implement signed images verification (#215)
* [#91] Provide unit tests covering signed images verification (#220)
* [#213] Add quiet flag, to the list command. (#221)
* [#217] CLI Remove command improvements (#224)

---------

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Stoyan Zoubev <[email protected]>
Signed-off-by: Kristiyan Gostev <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Daniel Milchev <[email protected]>
Co-authored-by: Stoyan Zoubev <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-milchev daniel-milchev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M5
Development

Successfully merging a pull request may close this issue.

Improve containerd client unit tests bosch-io/container-management
4 participants
@konstantina-gramatova @dimitar-dimitrow @daniel-milchev @k-gostev