Implement signed images verification #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitar-dimitrow
force-pushed
the
notation-verify-image
branch
from
b7de03b to
958ff26
Compare
k-gostev
suggested changes
Nov 28, 2023
There was a problem hiding this comment.
Currently starting the container management as a service fails with:
panic: neither $XDG_CONFIG_HOME nor $HOME are defined
goroutine 1 [running]:
github.com/notaryproject/notation-go/dir.loadUserPath()
pkg/mod/github.com/notaryproject/[email protected]/dir/path.go:85 +0xe0
github.com/notaryproject/notation-go/dir.init.0()
pkg/mod/github.com/notaryproject/[email protected]/dir/path.go:77 +0x1c
This must be mitigated
dimitar-dimitrow
force-pushed
the
notation-verify-image
branch
from
68579fe to
89fdfed
Compare
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitar-dimitrow
force-pushed
the
notation-verify-image
branch
from
89fdfed to
07d4d28
Compare
k-gostev
suggested changes
Dec 12, 2023
Signed-off-by: Dimitar Dimitrov <[email protected]>
k-gostev
approved these changes
Dec 12, 2023
k-gostev
pushed a commit
that referenced
this pull request
Apr 30, 2024
* [#67] Implement signed images verification --------- Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitar-dimitrow
added a commit
that referenced
this pull request
May 10, 2024
[#234] Merge `dev-m5` branch into `main` * [#51] Improve containerd client unit tests (#203) * [#201] Optimized, deterministic intermediate desired state feedback messages (#204) * [#208] Add file flag to the CLI create command (#209) * [#191] Container remains Stopped after container-management service restart (#214) * [#210] Remove command should accept more than one container ID (#212) * [#196] Starting of constantly restarting container fails (#216) * [#67] Implement signed images verification (#215) * [#91] Provide unit tests covering signed images verification (#220) * [#213] Add quiet flag, to the list command. (#221) * [#217] CLI Remove command improvements (#224) --------- Signed-off-by: Daniel Milchev [email protected] Signed-off-by: Stoyan Zoubev <[email protected]> Signed-off-by: Kristiyan Gostev <[email protected]> Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Daniel Milchev <[email protected]> Co-authored-by: Stoyan Zoubev <[email protected]> Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#67] Implement signed images verification
Signed-off-by: Dimitar Dimitrov [email protected]