Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve containerd client unit tests #203

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

daniel-milchev
Copy link
Contributor

@daniel-milchev daniel-milchev commented Oct 19, 2023

[#51] Improve containerd client unit tests
Signed-off-by: Daniel Milchev [email protected]

@dimitar-dimitrow dimitar-dimitrow changed the base branch from main to dev-m5 October 19, 2023 15:09
@dimitar-dimitrow dimitar-dimitrow linked an issue Oct 19, 2023 that may be closed by this pull request
@k-gostev k-gostev changed the title Imporved unit tests. Improve containerd client unit tests Oct 19, 2023
Copy link
Contributor

@k-gostev k-gostev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked into much details, but this is what catch my eye at a glance

containerm/ctr/ctrd_container_create_opts_test.go Outdated Show resolved Hide resolved
containerm/ctr/ctrd_container_create_opts_test.go Outdated Show resolved Hide resolved
containerm/ctr/ctrd_container_create_opts_test.go Outdated Show resolved Hide resolved
containerm/ctr/ctrd_client_test.go Outdated Show resolved Hide resolved
containerm/ctr/ctrd_client_test.go Outdated Show resolved Hide resolved
@dimitar-dimitrow dimitar-dimitrow merged commit 9c45fef into eclipse-kanto:dev-m5 Oct 26, 2023
@dimitar-dimitrow dimitar-dimitrow deleted the test-coverage branch October 26, 2023 08:39
k-gostev pushed a commit that referenced this pull request Nov 2, 2023
[#51] Improve containerd client unit tests

Signed-off-by: Daniel Milchev [email protected]
k-gostev pushed a commit that referenced this pull request Apr 30, 2024
[#51] Improve containerd client unit tests

Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow added a commit that referenced this pull request May 10, 2024
[#234] Merge `dev-m5` branch into `main`
* [#51] Improve containerd client unit tests (#203)
* [#201] Optimized, deterministic intermediate desired state feedback messages (#204)
* [#208] Add file flag to the CLI create command (#209)
* [#191] Container remains Stopped after container-management service restart (#214)
* [#210] Remove command should accept more than one container ID (#212)
* [#196] Starting of constantly restarting container fails (#216)
* [#67] Implement signed images verification (#215)
* [#91] Provide unit tests covering signed images verification (#220)
* [#213] Add quiet flag, to the list command. (#221)
* [#217] CLI Remove command improvements (#224)

---------

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Stoyan Zoubev <[email protected]>
Signed-off-by: Kristiyan Gostev <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Daniel Milchev <[email protected]>
Co-authored-by: Stoyan Zoubev <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve containerd client unit tests
3 participants