-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve containerd client unit tests #203
Merged
dimitar-dimitrow
merged 4 commits into
eclipse-kanto:dev-m5
from
bosch-io:test-coverage
Oct 26, 2023
Merged
Improve containerd client unit tests #203
dimitar-dimitrow
merged 4 commits into
eclipse-kanto:dev-m5
from
bosch-io:test-coverage
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-milchev
force-pushed
the
test-coverage
branch
from
October 19, 2023 14:55
bc20e96
to
1c029ff
Compare
daniel-milchev
force-pushed
the
test-coverage
branch
from
October 23, 2023 10:21
014010e
to
8a5786c
Compare
dimitar-dimitrow
force-pushed
the
test-coverage
branch
from
October 23, 2023 11:49
8a5786c
to
9186b20
Compare
dimitar-dimitrow
suggested changes
Oct 24, 2023
daniel-milchev
force-pushed
the
test-coverage
branch
from
October 24, 2023 10:00
9186b20
to
3df3168
Compare
k-gostev
suggested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not looked into much details, but this is what catch my eye at a glance
Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev
force-pushed
the
test-coverage
branch
from
October 25, 2023 09:43
e540f1c
to
86debd2
Compare
Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Daniel Milchev [email protected]
daniel-milchev
force-pushed
the
test-coverage
branch
from
October 25, 2023 09:48
86debd2
to
390e05c
Compare
k-gostev
approved these changes
Oct 25, 2023
dimitar-dimitrow
approved these changes
Oct 26, 2023
k-gostev
pushed a commit
that referenced
this pull request
Nov 2, 2023
[#51] Improve containerd client unit tests Signed-off-by: Daniel Milchev [email protected]
k-gostev
pushed a commit
that referenced
this pull request
Apr 30, 2024
[#51] Improve containerd client unit tests Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow
added a commit
that referenced
this pull request
May 10, 2024
[#234] Merge `dev-m5` branch into `main` * [#51] Improve containerd client unit tests (#203) * [#201] Optimized, deterministic intermediate desired state feedback messages (#204) * [#208] Add file flag to the CLI create command (#209) * [#191] Container remains Stopped after container-management service restart (#214) * [#210] Remove command should accept more than one container ID (#212) * [#196] Starting of constantly restarting container fails (#216) * [#67] Implement signed images verification (#215) * [#91] Provide unit tests covering signed images verification (#220) * [#213] Add quiet flag, to the list command. (#221) * [#217] CLI Remove command improvements (#224) --------- Signed-off-by: Daniel Milchev [email protected] Signed-off-by: Stoyan Zoubev <[email protected]> Signed-off-by: Kristiyan Gostev <[email protected]> Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Daniel Milchev <[email protected]> Co-authored-by: Stoyan Zoubev <[email protected]> Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#51] Improve containerd client unit tests
Signed-off-by: Daniel Milchev [email protected]