Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command should accept more than one container ID #210

Closed
k-gostev opened this issue Nov 9, 2023 · 0 comments · Fixed by #212
Closed

Remove command should accept more than one container ID #210

k-gostev opened this issue Nov 9, 2023 · 0 comments · Fixed by #212
Assignees
@daniel-milchev
Labels
task Single unit of work
Milestone
M5

Comments

@k-gostev
Copy link
Contributor

k-gostev commented Nov 9, 2023

The remove command should be enhanced as describe here in Task 1. All unit and integration tests should be implemented regarding this enhancement as well.
@k-gostev k-gostev added the task Single unit of work label Nov 9, 2023
@k-gostev k-gostev added this to the M5 milestone Nov 9, 2023
@k-gostev k-gostev moved this to In Progress (max 10) in Eclipse Kanto Nov 9, 2023
@k-gostev k-gostev moved this from In Progress (max 10) to Todo in Eclipse Kanto Nov 15, 2023
@daniel-milchev daniel-milchev moved this from Todo to In Progress (max 10) in Eclipse Kanto Nov 16, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Nov 21, 2023
@daniel-milchev
[eclipse-kanto#210] Changed remove command to accept more than one co…
222c025 
…ntainer.

Signed-off-by: Daniel Milchev [email protected]
@daniel-milchev daniel-milchev mentioned this issue Nov 21, 2023
Merged
@daniel-milchev daniel-milchev moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Nov 21, 2023
@k-gostev k-gostev moved this from Ready for Review (max 3) to In Progress (max 10) in Eclipse Kanto Nov 21, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Nov 22, 2023
@daniel-milchev
[eclipse-kanto#210] Added unit tests, fixed logic and changed accordi…
473f3e2 
…ng to comments.

Signed-off-by: Daniel Milchev [email protected]
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Nov 22, 2023
@daniel-milchev
[eclipse-kanto#210] Fixed lint suggestions.
54039ca
@daniel-milchev daniel-milchev moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Nov 22, 2023
@k-gostev k-gostev linked a pull request Nov 23, 2023 that will close this issue
Remove command should accept more than one container ID #212
Merged
@k-gostev k-gostev moved this from Ready for Review (max 3) to In Review (max 3) in Eclipse Kanto Nov 23, 2023
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Nov 23, 2023
@daniel-milchev
[eclipse-kanto#210] Changed wording.
37975e7
dimitar-dimitrow pushed a commit that referenced this issue Nov 23, 2023
@daniel-milchev
Remove command should accept more than one container ID (#212)
27df4f0 
[#210] Remove command should accept more than one container ID

Signed-off-by: Daniel Milchev [email protected]
@dimitar-dimitrow dimitar-dimitrow moved this from In Review (max 3) to Done in Eclipse Kanto Nov 23, 2023
@k-gostev k-gostev mentioned this issue Nov 27, 2023
Closed
k-gostev pushed a commit that referenced this issue Apr 30, 2024
@daniel-milchev @k-gostev
Remove command should accept more than one container ID (#212)
e978b5f 
[#210] Remove command should accept more than one container ID

Signed-off-by: Daniel Milchev [email protected]
dimitar-dimitrow added a commit that referenced this issue May 10, 2024
@k-gostev @daniel-milchev
@stoyan-zoubev @dimitar-dimitrow
Merge dev-m5 into main (#235)
a951f1c 
[#234] Merge `dev-m5` branch into `main`
* [#51] Improve containerd client unit tests (#203)
* [#201] Optimized, deterministic intermediate desired state feedback messages (#204)
* [#208] Add file flag to the CLI create command (#209)
* [#191] Container remains Stopped after container-management service restart (#214)
* [#210] Remove command should accept more than one container ID (#212)
* [#196] Starting of constantly restarting container fails (#216)
* [#67] Implement signed images verification (#215)
* [#91] Provide unit tests covering signed images verification (#220)
* [#213] Add quiet flag, to the list command. (#221)
* [#217] CLI Remove command improvements (#224)

---------

Signed-off-by: Daniel Milchev [email protected]
Signed-off-by: Stoyan Zoubev <[email protected]>
Signed-off-by: Kristiyan Gostev <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Co-authored-by: Daniel Milchev <[email protected]>
Co-authored-by: Stoyan Zoubev <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-milchev daniel-milchev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M5
Development

Successfully merging a pull request may close this issue.

Remove command should accept more than one container ID bosch-io/container-management
3 participants
@dimitar-dimitrow @daniel-milchev @k-gostev