Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to output test results to file #1241

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Sep 21, 2018

Close #1260

Part of https://github.com/brave/devops/issues/79

Added option to specify file for test output (results).

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@mihaiplesa mihaiplesa self-assigned this Sep 21, 2018
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@w0ts0n w0ts0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@w0ts0n w0ts0n merged commit c92c037 into master Sep 22, 2018
@w0ts0n w0ts0n deleted the added-option-to-output-test-results-to-file branch September 22, 2018 00:36
@mihaiplesa mihaiplesa restored the added-option-to-output-test-results-to-file branch September 28, 2018 16:02
@mihaiplesa mihaiplesa deleted the added-option-to-output-test-results-to-file branch September 28, 2018 16:12
@bsclifton
Copy link
Member

@mihaiplesa added merged/0.56.x label; is this supposed to go into 0.55.x also? If so, let's merge and put the merged/0.55.x on it instead 😄 I also noticed the issue this fixes is still open?

@mihaiplesa
Copy link
Contributor Author

mihaiplesa commented Sep 28, 2018

Yes, I created the issue after the PR so it didn't get closed, should have been into 0.55.x as well.

@bsclifton
Copy link
Member

@mihaiplesa ok great- I just merged with 0.55.x with e21fb29 😄

@mihaiplesa
Copy link
Contributor Author

boom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants