Tor connection timeout is too short

[fmarier]

When opening a Tor window, the tor daemon needs to start up and connect to the Tor network. While it's doing that, we should a notification:

Once it's done, we change to a successful notification:

In cases of failure, we show an error:

The problem is that the error notification is shown unconditionally after a 30-sec timeout. Sometimes it takes longer than 30s for a connection to be established and in that case, we show the error notification and then a few seconds later, it gets replaced with a success notification, which is pretty confusing.

[fmarier]

The proposed solution (thanks to @rmcfadden3 and @aguscruiz) is to add a second timer:

1. "Tor is connecting…" (no change)
2. [30 seconds pass]
3. "Still connecting (there's some slowness in the Tor network)" (new string, same background color as the "Tor is connecting" message)
4. [30 seconds pass]
5. "Tor connection failed" / "Tor connected successful" (no change)

[fmarier]

cc @boocmp

[MadhaviSeelam]

Verification In progress using

Brave | 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 11 Version 21H2 (Build 22000.1335)

1. Install 1.47.126
2. launch Brave
3. open brave://settings/privacy in a new-tab
4. enable Use Bridges in Tor windows section
5. select meek-azure in Select a built-in-bridge drop-down menu
6. click Apply changes
7. click hamburger menu >> New private window with Tor

step 4	step 5	initial tor connection	still connecting	Tor failed

[MadhaviSeelam]

@boocmp any update on above issue as error message shown for each status takes > 2 minutes
cc: @fmarier

https://bravesoftware.slack.com/archives/C85NV6NSG/p1671045026328789

[LaurenWags]

cc @rebron on #24978 (comment)

[LaurenWags]

Removing QA/Blocked per today's desktop planning meeting. cc-ing @GeetaSarvadnya @btlechowski @kjozwiak to check this issue.

We decided to confirm that the expected messages display and @MadhaviSeelam will log a follow up issue for the timing if it is still problematic.

cc @rebron

[btlechowski]

Verification passed on

Brave	1.47.169 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Ubuntu 18.04 LTS

Verified Tor connection indicator works properly when connection is successful

Connecting:

Connected:

Verified Tor connection indicator works properly when connection has problems

Note used STR from #24978 (comment)

Connecting:

Connection takes longer than expected

Connection failed

Time between states was >2minutes

Logged Tor connection indicator flashes red just before successfully connecting to Tor #27746
Logged Some string are not translated in Tor connection indicator #27747

[GeetaSarvadnya]

Verified on

Brave | 1.47.169 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 10 Version 21H2 (Build 19044.2364)

• Verified the test plan from Tor connection progress improved. Added slow phase. brave-core#15505

1. Install 1.47.169
2. launch Brave
3. open brave://settings/privacy in a new-tab
4. enable Use Bridges in Tor windows section
5. select meek-azure in Select a built-in-bridge drop-down menu
6. click Apply changes
7. click hamburger menu >> New private window with Tor

Once I open the Tor windows I am seeing the different messages as below:

1. 1st message is Disconnected remains on the TOR windows around 2 to 3 seconds
2. 2nd message Tor connection failed flashes and go off in a fraction of seconds
3. 3rd message Tor is connecting remains on the TOR windows for around 9 mins 15 seconds
4. 6th message Tor connection failed is shown after 9 mins 15 seconds

1st msg	2nd msg	3rd msg	4th msg	5th msg	6th msg

[MadhaviSeelam]

Verification PASSED using

Brave | 1.47.169 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Retested with 1.47.169

• Confirmed Tor is connecting..., Still connecting... and Tor connection failed messages are shown as expected
• Tor connection message are taking longer to show than expected timeout of 45 seconds. Filed Tor connection messages take longer to show than expected times. #27766

Tor is connecting...	Still connecting...	Tor connection failed

[stephendonner]

Verification PASSED using

Brave	1.47.171 Chromium: 109.0.5414.87 (Official Build) (x86_64)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	macOS Version 11.7.2 (Build 20G1020)

1. installed 1.47.171
2. launched Brave
3. opened brave://settings/privacy in a new-tab
4. enabled Use Bridges in Tor windows section
5. selected meek-azure in Select a built-in-bridge drop-down menu
6. clicked Apply changes
7. clicked hamburger menu >> New private window with Tor

Once I opened the Tor windows I am seeing the different messages as below:

1. 1st message is Disconnected remains on the TOR windows around 2 to 3 seconds
2. 2nd message Tor connection failed flashes and go off in a fraction of seconds
3. 3rd message Tor is connecting remains on the TOR windows for around 9 mins 15 seconds
4. 6th message Tor connection failed is shown after 9 mins 15 seconds

1st msg	2nd msg	3rd msg	4th msg	5th msg	6th msg

[boocmp]

The Meek-Azure bridge has begun to show signs of life, it is trying to create a connection and periodically sends a progress message (14% or 15% of Handshake with a relay done). We're resetting the connection timer at every progress message so this causes the messages "still connecting" and "Tor is connecting" to swap each other until the bridge stops trying to connect. We need to check 'count' field of the progress message to determine that is the same as we received early and ignore it.