Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grandfather unverified similar to unconnected state for ads #27989

Closed
btlechowski opened this issue Jan 23, 2023 · 0 comments
Closed

Make grandfather unverified similar to unconnected state for ads #27989

btlechowski opened this issue Jan 23, 2023 · 0 comments

Comments

@btlechowski
Copy link

btlechowski commented Jan 23, 2023

After upgrade to 1.48.x aka grandfather unverified, we shouldn't show ads stats at all as they does not matter, instead we should show message similar to unconnected state cc @tmancey

Steps to Reproduce

  1. Install 1.47.x
  2. Clean profile
  3. Enable rewards and ads
  4. Upgrade to 1.48.x
  5. Open brave://rewards

Actual result:

We do not immediately offer solution to the problem aka connect to custodian.
We ask users to click Learn More to find the solution in wall of text.
Misleading users as it says that user will earn BAT by viewing ads in this state
image

Expected result:

Show message urging users to connect to a custodian, similar to unconnected state shown below.
Also include link to https://brave.com/rewards-changes, explaining the changes to existing users.
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux

cc @tmancey @Miyayes @LaurenWags

@btlechowski btlechowski changed the title Make unverified and grandfather unverified states similar for ads Make grandfather unverified similar to unverified states for ads Jan 23, 2023
@btlechowski btlechowski changed the title Make grandfather unverified similar to unverified states for ads Make grandfather unverified similar to unverified state for ads Jan 23, 2023
@btlechowski btlechowski changed the title Make grandfather unverified similar to unverified state for ads Make grandfather unverified similar to unconnected state for ads Jan 23, 2023
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants