Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ads status header hosts list #26904

Closed
aseren opened this issue Nov 21, 2022 · 2 comments · Fixed by brave/brave-core#16043
Closed

Update ads status header hosts list #26904

aseren opened this issue Nov 21, 2022 · 2 comments · Fixed by brave/brave-core#16043
Assignees
@aseren
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@aseren
Copy link

aseren commented Nov 21, 2022 •
edited
Loading

Add following hosts: safesearch.brave.com, safesearch.brave.software, safesearch.bravesoftware.com

The X-Brave-Ads-Enabled header description: https://github.com/brave/brave-browser/wiki/Custom-Headers#x-brave-ads-enabled
@aseren aseren added feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 21, 2022
@aseren aseren added the QA/Yes label Nov 21, 2022
@aseren aseren mentioned this issue Nov 21, 2022
Merged
25 tasks
@aseren aseren self-assigned this Nov 22, 2022
aseren added a commit to brave/brave-core that referenced this issue Nov 22, 2022
@aseren
Update allowed brave search hosts list
9b45edf 
Fix brave/brave-browser#26904
aseren added a commit to brave/brave-core that referenced this issue Nov 24, 2022
@aseren
Update allowed brave search hosts list
b5dd12c 
Fix brave/brave-browser#26904
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 30, 2022
@tmancey tmancey mentioned this issue Dec 1, 2022
Closed
@btlechowski
Copy link

btlechowski commented Jan 19, 2023 •
edited
Loading

Verification passed on

Brave 1.48.125 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#16043

Test case 1 - https://safesearch.brave.com/ - clean profile

Verified X-Brave-Ads-Enabled header is not set in the request after opening https://safesearch.brave.com/

image

Verified X-Brave-Ads-Enabled header is not set in the request after using the search box on https://safesearch.brave.com/
image

Test case 2 - https://safesearch.brave.com/ - ads enabled

Verified X-Brave-Ads-Enabled header is set in the request after opening https://safesearch.brave.com/
image

Verified X-Brave-Ads-Enabled header is set in the request after using the search box on https://safesearch.brave.com/
image

Test case 3 - window.brave.getCanSetDefaultSearchProvider on https://github.com/

window.brave.getCanSetDefaultSearchProvider
image

window.brave.setIsDefaultSearchProvider
image

Test case 4 - window.brave.getCanSetDefaultSearchProvider on https://safesearch.brave.com/

window.brave.getCanSetDefaultSearchProvider
image

window.brave.setIsDefaultSearchProvider
image

Test case 5 - https://github.com/ when ads enabled

Verified X-Brave-Ads-Enabled header is not set in the request
image

Test case 6 - https://safesearch.brave.com/ when ads disabled

ads disabled
image

Verified X-Brave-Ads-Enabled header is not set in the request after opening https://safesearch.brave.com/
image

Verified X-Brave-Ads-Enabled header is not set in the request after using the search box on https://safesearch.brave.com/
image

@btlechowski btlechowski added QA Pass-Linux QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 19, 2023
@btlechowski
Copy link

Verification passed on Brave v1.48.151 on Lenovo TB-8506FS (Android 11.0)

Verified test plan from brave/brave-core#16043

Test case 1 - https://safesearch.brave.com/ - clean profile

Verified X-Brave-Ads-Enabled header is not set in the request after opening https://safesearch.brave.com/
image

Verified X-Brave-Ads-Enabled header is not set in the request after using the search box on https://safesearch.brave.com/
image

Test case 2 - https://safesearch.brave.com/ - ads enabled

Verified X-Brave-Ads-Enabled header is set in the request after opening https://safesearch.brave.com/
image

Verified X-Brave-Ads-Enabled header is set in the request after using the search box on https://safesearch.brave.com/
image

Test case 3 - window.brave.getCanSetDefaultSearchProvider on https://github.com/

window.brave.getCanSetDefaultSearchProvider
image

window.brave.setIsDefaultSearchProvider
image

Test case 4 - window.brave.getCanSetDefaultSearchProvider on https://safesearch.brave.com/

window.brave.getCanSetDefaultSearchProvider
image

window.brave.setIsDefaultSearchProvider
image

Test case 5 - https://github.com/ when ads enabled

Verified X-Brave-Ads-Enabled header is not set in the request
image

Test case 6 - https://safesearch.brave.com/ when ads disabled

Verified X-Brave-Ads-Enabled header is not set in the request after opening https://safesearch.brave.com/
image

Verified X-Brave-Ads-Enabled header is not set in the request after using the search box on https://safesearch.brave.com/
image

@btlechowski btlechowski added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 3, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Update ads status header hosts list. brave/brave-core
3 participants
@btlechowski @brave-builds @aseren