-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable/hide audio mute button on tab #6690
Comments
Thank you @bsclifton, I gave it a thumbs up. |
Was just lookin' for a way to disable it, as I'm keeping muting tabs instead of closing them, or toggling... |
I am with you on this. Pinned tabs are especially annoying. Maybe just have the mute button not visible unless the tab is active? |
Very annoying indeed... as much as Brave helps you "stay in the flow" by recently working reliably enough, this thing ejects you out of "the flow" in a split-second... then you say: ah yes, I clicked the mute button again, that's what happened... I would rate this feature 1 out of 10 or even less. Please consider fixing if possible and thank you for great work :) |
I am literally switching back to chrome because of this. Let me guess, one developer wanted the feature and here we are dealing with it... in what world do i want a fucking mute button the size of the 'x' and almost as big as the whole tab so i can fat finger it every, single, fucking, time... |
@rebron can we maybe up priority on this one? |
@rebron Perhaps the best solution is to only allow the click-action to occur if the tab is selected. Then you retain the mute/play indicator status and the button usefulness where it's really important. |
Or, hear me out: put a toggle to remove this useless 'feature' |
@bradleyrichter I think having it only show up on an active is a good idea, but I think it will still have the same level of frustration in some cases. For example, the situation is REALLY bad for pinned tabs, and would still be present for users who are trying to rearrange pinned tabs. It is only one extra click to alt-click and select "Mute Site". I feel this "feature" should just be removed altogether, as it will likely be frustrating to most users even if it shows up only on the active tab. There are also "Mute Tab" extensions on the extension store for users who really want a "fast click" option to mute the tab. |
@rebron what do you think about adding a toggle for this (not sure where- appearance? we almost need a new tabs section in settings) and setting the default to OFF (matching Chrome default behavior). For folks wanting it, they could opt-in |
I'm on Version 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit) and the problem is gone! |
Any update? It's so annoying |
I did an update and this is fix for me. |
I'm using |
+1 from Community https://community.brave.com/t/tab-mute-button/150875?u=eljuno |
Since Brave is chromium based, would it be a chrome thing or would it be possible for Brave to implement this themselves? In chrome latest version and for a while the mute tab button doesn't do anything. I don't know if mute tab is apart of chrome in button form on the tab itself. This is the feature or ability that we or some are looking for for those of us that have many tabs open. Maybe chrome can be looked at to why the mute function doesn't do anything in chrome and try to see if it can be applied to Brave. I see people saying not to remove it, it could be looked into to only be able to disable it completely but enabled by default for those that find it useful. If Brave could make this happen then I would be using Brave full time but until the mute function can be disabled I am unable to use it and am stuck with chrome. |
+1, I click on this icon almost every time I want to switch to a tab with sound. It is very annoying and an UX mistake, this is not what the user wants most of the time he click on a tab, and the icon occupies most of the space property. Make it a right click feature for god sake. |
Okay, I just worked out what's going on - Chromium set the tab-audio-muting flag to expire after 107. As a temporary solution, if you enable chrome://flags/#temporary-unexpire-flags-m107 then you should be able to use the #tab-audio-muting flag again. I'll look into a more permanent solution. |
Verification
|
Brave | 1.48.131 Chromium: 109.0.5414.87 (Official Build) beta (x86_64) |
---|---|
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
OS | macOS Version 11.7.2 (Build 20G1020) |
Case 1: Mute indicators are not clickable -PASSED
- installed
1.48.131
- launched Brave
- opened
brave://settings/appearance
- confirmed
Disable mute function in tab speaker icons
setting is available and toggledOff
as a default - opened a few audio playing tabs
- clicked on the speaker icon of an audio playing tab
- confirmed audio is muted as expected
- returned to
brave://settings/appearance
- toggled
On
Disable mute function in tab speaker icons
setting - clicked on the speaker icon of audio playing tab
Confirmed speaker icon is not clickable when the setting is enabled
ex1 | ex2 | ex3 |
---|---|---|
Case 2: Mute tab/Unmute tab in the context menu - PASSED
- new profile
Disable mute function in tab speaker icons
setting is disabled as a default- right click on audio playing tab to open context menu
- confirmed
Mute tab
is available above existingMute site
option - confirmed audio playing tab is muted successfully
- clicked Unmute tab in the context menu
- confirmed audio played again
Confirmed Mute tab/Unmute tab works as expected.
ex1 | ex2 | ex3 | ex4 |
---|---|---|---|
Case 3: Mute site/Unmute site in the context menu - PASSED
- continue from Case 1:
Disable mute function in tab speaker icons
setting is enabled- Mute indicator is not clickable
- right click on audio playing tab to open context menu
- confirmed
Mute site
is available above existingMute site
option - confirmed audio playing tab is muted successfully
- clicked Unmute site in the context menu
- confirmed audio played again
- click again
Mute site
and clickUnmute tab
Mute site/Unmute site worked as expected and Mute tab/Unmute Tab over rides the option
ex1 | ex2 | ex3 | ex4 |
---|---|---|---|
Case 4: Mute/Unmute audio playing pinned tabs and multiple tabs open - PASSED
- new profile
Disable mute function in tab speaker icons
setting is disabled as a default- pin couple of tabs
- play media on one of the pinned tab
- switch to another pinned tab
- Mute the pinned tab with audio playing
- confirmed audio playing tab is muted successfully
- activate the pinned tab with audio playing
- clicked Unmute tab in the context menu
- confirmed audio played again
Confirmed Mute/Unmuting audio works on pinned tabs
Confirmed when audio playing tabs are clicked, tabs are activated instead of muting the audio
ex1 | ex2 | ex3 | ex4 | ex5 |
---|---|---|---|---|
Verification
Case 1: Mute indicators are not clickable -
Confirmed speaker icon is not clickable when the setting is enabled
Case 2: Mute tab/Unmute tab in the context menu -
Confirmed Mute tab/Unmute tab works as expected.
Mute site/Unmute site worked as expected and Mute tab/Unmute Tab over rides the option
Case 4: Mute/Unmute audio playing pinned tabs and multiple tabs open -
Confirmed Mute/Unmuting audio works on pinned tabsConfirmed when audio playing tabs are clicked, tabs are activated instead of muting the audio
|
I also encountered this issue - just providing more information, although in Thorium. I ended up here, via a Google search though. :-) I started to research this because it happened for the third time now. Especially when I have many tabs open. The feature is not useless, but it conflicts with my browsing behaviour, and since it interfered once too often in my case, I decided to invest time into researching how to get rid of it. Going back to the roots, keeping it simple. :-) (Actually, if it is a video I am playing such as on youtube, I tend to click on the video to stop it; and if I have to insta-close it, I just close the tab directly via mouse or keyboard command, so the disable audio button isn't too terribly useful anyway in my case.) |
@rubyFeedback in Brave we have a setting for enabling/disabling this behaviour if you want to try it out? |
Thank you for fixing this! |
Thank you! 🙏 |
I think this function should be disabled by default, my god, I spent a few minutes researching whether it is possible to disable it, annoying feature, you keep missclick, I imagine that many people prefer to change browsers instead of using Brave , why keep a feature with usability problems enabled by default? |
Description
I've had a surprising number of users report that they very frequently mute a tab playing audio in the background on accident when moving or switching between tabs:
Note that there used to be a Chromium flag to enable/disable the mute tab button that was removed.
It may be good for future releases to add the option to disable or hide this feature should users continue to have this issue.
Miscellaneous Information:
User reports:
https://community.brave.com/t/please-add-an-option-to-disable-the-tab-audio-muting-button/89927
https://community.brave.com/t/how-do-i-turn-off-the-new-mute-sound-button-in-tabs/87439/3
https://www.reddit.com/r/brave_browser/comments/dow6hb/muteunmute_tabs/
https://www.reddit.com/r/brave_browser/comments/dirtje/tab_disable_mute_toggle_functionality/
The text was updated successfully, but these errors were encountered: