-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make muting sites easier #16269
Make muting sites easier #16269
Conversation
f8c5353
to
37211a9
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think you might want to wait for @simonhong 's review :)
chromium_src/chrome/browser/ui/views/tabs/alert_indicator_button.cc
Outdated
Show resolved
Hide resolved
A Storybook has been deployed to preview UI for the latest push |
88a096e
to
e1f706c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ 👍🏼
e1f706c
to
457940b
Compare
457940b
to
119739a
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
3292a03
to
8e7412c
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
LGTM (with 1 nit)
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#6690
This a couple of things to make muting a bit more customizable:
(Un)Mute tab
entry to the context menu which mutes/unmutes only the tab (or selected tabs) rather than the origins (or selected origins).Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Disable mute function in tab speaker icons
Mute tab
entry.Mute site
entry.Mute/unmute
tabs.Mute/unmute
sites option.