Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make muting sites easier #16269

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Make muting sites easier #16269

merged 11 commits into from
Dec 13, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Dec 7, 2022

Resolves brave/brave-browser#6690

This a couple of things to make muting a bit more customizable:

  • Adds an option to brave://settings/system for toggling whether or not the mute indicators on tabs are clickable
    image
  • Adds a new (Un)Mute tab entry to the context menu which mutes/unmutes only the tab (or selected tabs) rather than the origins (or selected origins).
    image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Brave
  2. Mute indicators should be clickable
  3. In brave://settings/appearance, enable Disable mute function in tab speaker icons
  4. Mute indicators should not be clickable
  5. Right click on a tab and you should see a new Mute tab entry.
  6. It should be above the existing Mute site entry.
  7. It should be possible to Mute/unmute tabs.
  8. It should override the Mute/unmute sites option.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you might want to wait for @simonhong 's review :)

browser/ui/tabs/brave_tab_menu_model.cc Show resolved Hide resolved
browser/ui/tabs/brave_tab_menu_model.h Outdated Show resolved Hide resolved
browser/ui/tabs/brave_tab_strip_model.h Show resolved Hide resolved
browser/ui/views/tabs/brave_tab_context_menu_contents.cc Outdated Show resolved Hide resolved
browser/ui/views/tabs/brave_tab_context_menu_contents.cc Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src LGTM (with 1 nit)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 89cb653 into master Dec 13, 2022
@fallaciousreasoning fallaciousreasoning deleted the mute-button branch December 13, 2022 22:49
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable/hide audio mute button on tab
5 participants