Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global "clear cookies when you close all windows" setting conflicts with 1PES #22493

Closed
goodov opened this issue Apr 22, 2022 · 8 comments · Fixed by brave/brave-core#13127, brave/brave-variations#262 or brave/brave-variations#263
Closed

Global "clear cookies when you close all windows" setting conflicts with 1PES #22493

goodov opened this issue Apr 22, 2022 · 8 comments · Fixed by brave/brave-core#13127, brave/brave-variations#262 or brave/brave-variations#263
Assignees
@goodov
Labels
bug OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.38.x - Release

Comments

@goodov
Copy link
Member

goodov commented Apr 22, 2022 •
edited
Loading

https://community.brave.com/t/brave-clearing-cookies-when-i-close-tabs/366275

I have it set to do so in Settings (clear all cookies upon closing all windows). Beginning today, Brave seems to be deleting cookies as soon as I close the tab even if the rest of the window is still open, meaning if I log into a site and then close that tab, I need to login to that site again.

Steps to Reproduce:

  1. I login to a site.
  2. I close the tab with that site while leaving the window + other tabs open.
  3. I open that site again in a new tab.
    Actual Result: The site opens in the tab with me signed out. I need to sign-in again.

Expected result: Prior to today, the site would have left me signed in until I closed the entire browser window.
@goodov goodov added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 22, 2022
@goodov goodov self-assigned this Apr 22, 2022
@goodov goodov removed the OS/Android Fixes related to Android browser functionality label Apr 22, 2022
@goodov goodov mentioned this issue Apr 22, 2022
Merged
25 tasks
This was referenced Apr 22, 2022
Merged
Merged
@rebron rebron mentioned this issue Apr 22, 2022
Closed
@goodov goodov added this to the 1.40.x - Nightly milestone Apr 22, 2022
@goodov
Copy link
Member Author

goodov commented Apr 22, 2022 •
edited
Loading

This issue is correlated with GMail login failures (HTTP 400 error) when Clear cookies and site data when you close all windows is enabled.

@Aloyah1
Copy link

Aloyah1 commented Apr 23, 2022

Hi, me too.

What to do ?

@kjozwiak
Copy link
Member

The above requires 1.38.106 or higher for 1.38.x verification 👍

@Aloyah1
Copy link

Aloyah1 commented Apr 23, 2022

Hi

The above requires 1.38.106 or higher for 1.38.x verification 👍

Sorry, but my system is Windows 10

@diracdeltas diracdeltas mentioned this issue Apr 23, 2022
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 26, 2022 •
edited
Loading

Verification PASSED on

Brave | 1.38.106 Chromium: 101.0.4951.41 (Official Build) (64-bit)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | Windows 10 Version 21H2 (Build 19044.1645)
  • Verified the STR grom the description and ensured that the logged-in sites are NOT logged out when the tab (site) is closed and reopened
  • Verified the gmail.com, Lastpass, and youtube.com sites and ensure sites are not logged out after closing and reopening the sites
  • Verified both clean and upgraded profile

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
@Aloyah1
Copy link

Aloyah1 commented Apr 27, 2022

Hi,

do you know when the final version will be released ?

@rebron
Copy link
Collaborator

rebron commented Apr 27, 2022

@Aloyah1 It will be available in the next couple of hours. It will be version 1.38.109.

@Aloyah1
Copy link

Aloyah1 commented Apr 27, 2022 •
edited
Loading

@Aloyah1 It will be available in the next couple of hours. It will be version 1.38.109.

@rebron Thanks for the information !

This was referenced Apr 28, 2022
Merged
Merged
This was referenced May 20, 2022
Closed
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.38.109 for Desktop, Android will follow shortly
c84c5af 
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
bug OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.38.x - Release
5 participants
@kjozwiak @goodov @rebron @GeetaSarvadnya @Aloyah1