Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Select Network field in the Custom Asset Modal #21656

Closed
Douglashdaniel opened this issue Mar 15, 2022 · 1 comment · Fixed by brave/brave-core#12697
Closed

Add a Select Network field in the Custom Asset Modal #21656

Douglashdaniel opened this issue Mar 15, 2022 · 1 comment · Fixed by brave/brave-core#12697
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
1.38.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need a Select Network field to the Add Custom Asset modal to allow adding custom assets for any chain.

Screen Shot 2022-03-14 at 7 51 47 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 15, 2022
@Douglashdaniel Douglashdaniel self-assigned this Mar 15, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Mar 15, 2022
Merged
24 tasks
@bbondy bbondy added this to Web3 Mar 17, 2022
@bbondy bbondy moved this to In Progress in Web3 Mar 17, 2022
@bbondy bbondy moved this from In Progress to In Review in Web3 Mar 17, 2022
@Douglashdaniel Douglashdaniel moved this from In Review to In Progress in Web3 Mar 18, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Mar 22, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 22, 2022
@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 22, 2022
Repository owner moved this from In Review to Done in Web3 Mar 22, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 8, 2022 •
edited
Loading

Verified using

Brave | 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | macOS Version 12.1 (Build 21C52)
  • Verified network selector in the Custom Asset Modal.
  • Entering the contract address will auto-populate the fields.
  • Added asset will show up in the portfolio page.
  • Asset added will contain the appropriate network pin.
  • Added asset will correctly display USD value of the asset.

Screen Shot 2022-04-07 at 4 49 12 PM

Screen Shot 2022-04-07 at 5 30 17 PM

Issues Encountered:

  • Added an asset contract that doesn't match network will result in some assets showing up in a loading state on the portfolio page. Ex: Added GALA Eth mainnet contract address but selected Binance Smart Chain Mainnet as the network in the form. This didnt populate automatically but after filling in the details and adding the asset, the result looks like below image.

Screen Shot 2022-04-07 at 4 50 55 PM

  • Quickswap (QUICK) doesn't show USD value for some reason (polygon variant)

Screen Shot 2022-04-07 at 5 19 07 PM

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.38.109 for Desktop, Android will follow shortly
c84c5af 
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add Custom Asset Network Selector brave/brave-core
2 participants
@Uni-verse @Douglashdaniel