Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Add Custom Asset Network Selector #12697

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Added a Network Selector to the Add Custom Asset form to allow users to select which network they are adding a Token too.

Resolves brave/brave-browser#21656

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Adding a asset on Ethereum Mainnet:

Screen.Recording.2022-03-22.at.9.30.45.AM.mov

Adding a asset on BSC Mainnet:

Screen.Recording.2022-03-22.at.10.21.54.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Mar 22, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 22, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 22, 2022
@Douglashdaniel Douglashdaniel merged commit 204904b into master Mar 22, 2022
@Douglashdaniel Douglashdaniel deleted the add-custom-asset-network-selector branch March 22, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Select Network field in the Custom Asset Modal
3 participants