Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Multichain Support on Portfolio and Account UI #12595

Merged
merged 1 commit into from
Mar 21, 2022
Merged

feat(wallet): Multichain Support on Portfolio and Account UI #12595

merged 1 commit into from
Mar 21, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Mar 14, 2022 •
edited
Loading

Description

Multichain UI Support on the Portfolio and Accounts pages.

  1. Can now view all Tokens and Balances from each of your EVM chains on the Portfolio and Accounts pages.

  2. Can now view Solana balances on the Portfolio and Accounts pages.

  3. Tokens for all Chain's and CoinType's are now combined in the Edit Visible Assets modal and can be Added or Removed (Support for adding a Custom token will be handled here Add a Select Network field in the Custom Asset Modal brave-browser#21656).

  4. Since each coinType has it's own default selectedNetwork pref, we now have a selectedCoin state that will help the front-end determine what network a user left on. (Currently will default to BraveWallet.CoinType.ETH until this is implement Add SetSelectedCoin and GetSelectedCoin in mojom brave-browser#21465)

  5. Solana and Filecoin transactions and networks/accounts will not be included in Account/Network selectors until Transaction Creation is supported in these 2 issues (Implement transaction creation for sending SOL and SPL tokens brave-browser#20698, Add FilTxService and enable sending FIL transactions in UI brave-browser#20893)

  6. Introduced a isTestNetworksEnabled state that will either show/hide our known supported TestNetworks/Tokens in the UI (Currently will default to true until this is implemented Add showTestNetworks user pref in Settings brave-browser#21650)

  7. Tokens are currently sorted by CoinType on the Portfolio page and for now all TestNetwork tokens will not be visible on the Portfolio page until custom sorting is implemented here Build out Portfolio Network Filter for Multi Chain support brave-browser#20780.

Resolves brave/brave-browser#20854
Resolves brave/brave-browser#21066

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2022-03-11.at.12.30.57.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Mar 14, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 14, 2022
@Douglashdaniel Douglashdaniel changed the title feat(wallet): Multichain Support in Portfolio UI feat(wallet): Multichain Support on Portfolio and Account UI Mar 15, 2022
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch 2 times, most recently from df4cd76 to 26d6cc3 Compare March 15, 2022 19:03
@Douglashdaniel Douglashdaniel marked this pull request as ready for review March 15, 2022 19:04
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner March 15, 2022 19:04
@github-actions github-actions bot added rebase and removed rebase labels Mar 15, 2022
@brave-builds brave-builds force-pushed the multichain-support-portfolio-ui branch from 26d6cc3 to 0473259 Compare March 15, 2022 19:07
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from 0473259 to c81bf00 Compare March 15, 2022 19:39
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from c81bf00 to 6222ec2 Compare March 15, 2022 22:20
josheleonard
josheleonard suggested changes Mar 15, 2022
View reviewed changes
components/brave_wallet_ui/common/async/handlers.ts Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Show resolved Hide resolved
components/brave_wallet_ui/common/async/lib.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/utils/api-utils.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/utils/network-utils.ts Outdated Show resolved Hide resolved
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch 2 times, most recently from fa62b40 to 371546e Compare March 16, 2022 02:33
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from 371546e to 88c5939 Compare March 16, 2022 02:54
josheleonard
josheleonard suggested changes Mar 16, 2022
View reviewed changes
components/brave_wallet_ui/utils/api-utils.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/assets.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/balance.ts Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/swap.test.ts Show resolved Hide resolved
components/brave_wallet_ui/common/reducers/wallet_reducer.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/stories/wallet-extension-panels.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/utils/api-utils.test.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/utils/api-utils.test.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/utils/api-utils.ts Show resolved Hide resolved
components/brave_wallet_ui/utils/network-utils.test.ts Outdated Show resolved Hide resolved
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch 2 times, most recently from 5fd5127 to 04bdee8 Compare March 16, 2022 21:39
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from 04bdee8 to e4ae674 Compare March 16, 2022 23:33
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from e4ae674 to 350d69c Compare March 17, 2022 03:09
josheleonard
josheleonard approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front end LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

onyb
onyb requested changes Mar 17, 2022
View reviewed changes
components/brave_wallet_ui/utils/api-utils.ts Show resolved Hide resolved
components/brave_wallet_ui/stories/wallet-extension-panels.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/stories/wallet-extension-panels.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/async/handlers.ts Show resolved Hide resolved
components/brave_wallet_ui/assets/asset-icons/sol-asset-icon.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/balance.ts Show resolved Hide resolved
components/brave_wallet_ui/components/desktop/popup-modals/edit-visible-assets-modal/index.tsx Show resolved Hide resolved
...let_ui/components/desktop/views/portfolio/components/accounts-and-transctions-list/index.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/components/desktop/views/portfolio/index.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/async/handlers.ts Show resolved Hide resolved
@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch 2 times, most recently from aaee811 to 34cc629 Compare March 17, 2022 23:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from 34cc629 to 00b3121 Compare March 18, 2022 18:40
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch 2 times, most recently from 0b8866c to fe9cdae Compare March 18, 2022 20:12
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

onyb
onyb approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Douglashdaniel Douglashdaniel force-pushed the multichain-support-portfolio-ui branch from fe9cdae to b8855fd Compare March 21, 2022 17:11
yrliou
yrliou approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for mojom and c++ changes

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 21, 2022
@Douglashdaniel Douglashdaniel merged commit 3ca77f6 into master Mar 21, 2022
@Douglashdaniel Douglashdaniel deleted the multichain-support-portfolio-ui branch March 21, 2022 19:07
@srirambv srirambv mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb approved these changes

@yrliou yrliou yrliou approved these changes

@josheleonard josheleonard josheleonard approved these changes

@muliswilliam muliswilliam Awaiting requested review from muliswilliam

Assignees

@Douglashdaniel Douglashdaniel

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.

Wire up GetBalance Method for Solana Return all EVM Network Tokens in Portfolio Page
5 participants
@Douglashdaniel @brave-builds @onyb @yrliou @josheleonard