Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unblocked cookie consent dialogs on some websites when the Cookie List is enabled #22032

Closed
ryanbr opened this issue Apr 1, 2022 · 7 comments · Fixed by brave/brave-core#12917
Closed

Fix unblocked cookie consent dialogs on some websites when the Cookie List is enabled #22032

ryanbr opened this issue Apr 1, 2022 · 7 comments · Fixed by brave/brave-core#12917
Assignees
@antonok-edm
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved.
Milestone
1.38.x - Release

Comments

@ryanbr
Copy link

ryanbr commented Apr 1, 2022

Description

Missing cookie messages, that should be blocked

Steps to Reproduce

Some examples, With

  1. Open https://jobsinkyoto.com/ ###cookieConsentModal is unblocked. jobsinkyoto.com##.vm--overlay is blocked

jobs-netw

jobsinkyoto.com:
Implemented here: https://github.com/easylist/easylist/blob/master/easylist_cookie/easylist_cookie_general_hide.txt#L2364

  1. Open https://safehaven.io/ safehaven.io###cookie-law-info-bar & safehaven.io##body,html:style(height: auto !important; overflow: auto !important) is unblocked

safehaven

safehaven.io:
Implemented here: https://github.com/easylist/easylist/blob/master/easylist_cookie/easylist_cookie_specific_uBO.txt#L309
safehaven.io###cookie-law-info-bar
safehaven.io##body,html:style(height: auto !important; overflow: auto !important)

Expected result:

Block the cookie messages

Reproduces how often:

Enable Easylist Cookie via chrome://flags/#brave-adblock-cookie-list-default

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Tested in Nightly [Version 1.39.22 Chromium: 100.0.4896.60

Other Additional Information:
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved. labels Apr 1, 2022
@ryanbr
Copy link
Author

ryanbr commented Apr 4, 2022

From https://community.brave.com/t/dk-com-cookie-policy/365710 https://www.dk.com/us/ should be blocked in standard mode. Using the filter ##dk-cookie-warning

@ryanbr
Copy link
Author

ryanbr commented Apr 5, 2022

airbnb4

Airbnb.com

easylist_cookie/easylist_cookie_general_hide.txt:###main-cookies-banner-container
easylist_cookie/easylist_cookie_general_hide.txt:##[data-testid="main-cookies-banner-container"]

@antonok-edm antonok-edm mentioned this issue Apr 6, 2022
Merged
25 tasks
@antonok-edm
Copy link
Collaborator

Also mentioning https://publicholidays.ee/ and https://www.overhemden.com/kronstadt-heren-overhemd-dean-bordeaux-rood-mao-flanel-regular-fit-ks3434bordeauxmel#01a7abd36065c0ad4c1159ddb9afa1e1 from a thread in Slack for QA testing purposes.

@ryanbr From my own testing, brave/brave-core#12917 should fix all of these sites.

@antonok-edm antonok-edm added this to the 1.39.x - Nightly milestone Apr 7, 2022
@brave-builds brave-builds mentioned this issue Apr 7, 2022
Merged
7 tasks
@kjozwiak kjozwiak added the QA/Yes label Apr 7, 2022
@antonok-edm antonok-edm added the OS/Android Fixes related to Android browser functionality label Apr 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.86 or higher for 1.38.x verification.

@antonok-edm antonok-edm changed the title Improve Easylist Cookie blocking Fix unblocked cookie consent dialogs on some websites when the Cookie List is enabled Apr 8, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.38.99 Chromium: 100.0.4896.127 (Official Build) beta (x86_64)
Revision ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS macOS Version 12.4 (Build 21F5048e)
brave://flags jobsinkyoto.com safehaven.io airbnb.com overhemden.com dk.com/us
Screen Shot 2022-04-18 at 4 19 23 PM Screen Shot 2022-04-18 at 4 14 36 PM Screen Shot 2022-04-18 at 4 14 48 PM Screen Shot 2022-04-18 at 4 14 59 PM Screen Shot 2022-04-18 at 4 15 12 PM Screen Shot 2022-04-18 at 4 15 42 PM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 running Android 12 using

Brave	1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12; Build/SP1A.210812.016
Safehaven Jobsinkyoto adblock airbnb overhemden dk
screenshot-1650587888662 screenshot-1650587897141 screenshot-1650587905944 screenshot-1650588090965 screenshot-1650588683972 screenshot-1650588738525

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 running Android 12 using

Brave	1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12; Build/SP1A.210812.016
adblock Jobsinkyoto safehaven airbnb overhemden dk
screenshot-1650590418315 screenshot-1650590514349 screenshot-1650590562071 screenshot-1650590588773 screenshot-1650590622154 screenshot-1650590650906

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Apr 27, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.38.109 for Desktop, Android will follow shortly
c84c5af 
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved.
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Force hide cosmetic filters from regional lists in Standard Shields mode brave/brave-core
6 participants
@stephendonner @ryanbr @kjozwiak @rebron @Uni-verse @antonok-edm