Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reader mode icon disappears after toggling on #18243

Closed
Tonev opened this issue Sep 21, 2021 · 9 comments · Fixed by brave/brave-core#12678
Closed

The reader mode icon disappears after toggling on #18243

Tonev opened this issue Sep 21, 2021 · 9 comments · Fixed by brave/brave-core#12678

Comments

@Tonev
Copy link
Contributor

Tonev commented Sep 21, 2021

Description

The reader mode icon immediately disappears after toggling on reader mode. Switching tabs or reloading the page via Shift + Reload brings the icon back.

Steps to Reproduce

  1. Ensure Speedreader is disabled via brave://settings/appearance.
  2. Open https://brave.com/blog or https://edition.cnn.com/2021/09/20/americas/canada-election-results-trudeau-o-toole-intl/index.html.
  3. Click on the reader mode icon in the address bar.

Actual result:

The reader mode icon disappears.

Expected result:

The reader mode icon shouldn't disappear.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.32.4 Chromium: 94.0.4606.50 (Official Build) nightly (64-bit)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner @keur

@bsclifton
Copy link
Member

@Tonev is this a duplicate of #18234?

@Tonev
Copy link
Contributor Author

Tonev commented Sep 21, 2021

@bsclifton

I think Reader mode and Speedreader are two different features. I tested the bug, filled by @stephendonner, and the behavior there is a bit different to what I'm describing in this bug report. I just included video recordings in the other Github ticket, please take a look at them, so we can determine whether we're talking about the same bug (duplicate) 👍

@Tonev
Copy link
Contributor Author

Tonev commented Sep 21, 2021

@bsclifton

  • Reader mode (this bug report)
vqGluwvvFP.mp4
ddFQzmsjX3.mp4

@iefremov
Copy link
Contributor

iefremov commented Nov 2, 2021

duplicate #18234

@iefremov iefremov closed this as completed Nov 2, 2021
@iefremov iefremov added the closed/duplicate Issue has already been reported label Nov 2, 2021
@Tonev
Copy link
Contributor Author

Tonev commented Nov 3, 2021

@iefremov

Are you sure it's a duplicate? After @bsclifton asked if this was a duplicate, I provided video recordings about my report and @stephendonner's report.

I also thought this wasn't a duplicate after @bsclifton didn't close it as such, and @stephendonner and @rebron labeled/moved the report.

@iefremov
Copy link
Contributor

iefremov commented Nov 3, 2021

my bad @Tonev , I've completely missed that comments - reopening. FWIW, i wasn't able to reproduce both issues on Beta

@iefremov iefremov reopened this Nov 3, 2021
@iefremov iefremov removed the closed/duplicate Issue has already been reported label Nov 3, 2021
@Tonev
Copy link
Contributor Author

Tonev commented Nov 3, 2021

@iefremov

I was able to easily reproduce the issue on Release, Beta, and Nightly.

  1. Ensured Speedreader was disabled via brave://settings/appearance.
  2. Opened https://brave.com/blog/.
  3. Clicked on the Reader mode icon in the address bar.
  4. Ensured the Reader mode icon disappeared.

Reloading the page brought back the Reader mode icon on all Release, Beta, and Nightly but then encountered the following bug: #18242.

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.32.88 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.33.52 Chromium: 95.0.4638.69 (Official Build) nightly (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Windows 7 Service Pack 1 (Build 7601)

I will update the report description since this bug is reproducible on all Release, Beta, and Nightly nowadays.

@stephendonner
Copy link

Verified PASSED using

Brave 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

Used the testplan from #18243 (comment)

Confirmed that the Speedreader icon not only persists after initial click (to enable the feature), but exists as a working On/Off toggle of the reader mode.

example example example example example
Screen Shot 2022-03-30 at 3 14 04 PM Screen Shot 2022-03-30 at 3 14 11 PM Screen Shot 2022-03-30 at 3 14 23 PM Screen Shot 2022-03-30 at 3 14 26 PM Screen Shot 2022-03-30 at 3 14 38 PM

@MadhaviSeelam
Copy link

Brave 1.38.78 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.593)
ex1 ex2 ex3 ex4 ex5
Speedreader disabled Speed reader popup Speed reader icon in the URL Turn on speed reader Turn off speed reader

avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants