Speedreader icon disappears after toggling on/off a few times

[stephendonner]

Description

Speedreader icon disappears after toggling on/off a few times; found while testing #18151

Steps to Reproduce

1. new profile
2. launch Brave
3. load https://brave.com/blog/
4. click on the reader-mode icon and click Turn on Speedreader
5. toggle Speedreader off
6. toggle Speedreader on

Actual result:

The Speedreader icon and mode disappear

(A shift + reload bring it back.)

Expected result:

Should still be an option to toggle Speedreader back on

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.32.5 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision	0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS	macOS Version 11.6 (Build 20G165)

/cc @keur

[stephendonner]

/cc @Tonev

[Tonev]

@stephendonner

Easily reproduced the issue you've described. I have some additions to your Github ticket that might be of interest to you and @keur.

• There is no need to reload the page via Shift + Reload, switching tabs is enough to bring back the icon.

Gp45oiaaKJ.mp4

• After hiding the Speedreader icon (performing your STR), if users close the tab, and then re-open it at some later point, the Speedreader icon will still be gone. In addition to this, I figured out that the Speedreader toggle won't go back to Disabled after clearing all browsing data. Please, confirm to me whether this is intentional behavior so I can fill another bug report regarding reader mode, if needed.

5QCo2SVmcj.mp4

---

P.S I filled the following reader mode bug - #18243. Thank you for tagging me, @stephendonner 👍

[kkuehlz]

Thanks guys. I have some other stuff I have to wrap up, but will get to these ASAP.

[Tonev]

@keur

Could you please let me know if I should fill an issue about the following:

I figured out that the Speedreader toggle won't go back to Disabled after clearing all browsing data.

That's shown in the second video in my previous comment. Long story short, enabling Speedreader for a specific web page makes that web page open in Speedreader mode every time, even if all browsing data is cleared.

Steps to reproduce:

1. Enable Speedreader via brave://settings/appearance.
2. Open https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.
3. Enable Speedreader mode via the icon in the address bar.
4. Close https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.
5. Open brave://settings/clearBrowserData.
6. Clear all browsing data for All time.
7. Open https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.

Actual result:

The article is still in Speedreader mode.

Expected result:

I guess the article shouldn't load in Speedreader mode after clearing all browsing data.

[kkuehlz]

@keur

Could you please let me know if I should fill an issue about the following:

I figured out that the Speedreader toggle won't go back to Disabled after clearing all browsing data.

That's shown in the second video in my previous comment. Long story short, enabling Speedreader for a specific web page makes that web page open in Speedreader mode every time, even if all browsing data is cleared.

Steps to reproduce:

1. Enable Speedreader via brave://settings/appearance.
2. Open https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.
3. Enable Speedreader mode via the icon in the address bar.
4. Close https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.
5. Open brave://settings/clearBrowserData.
6. Clear all browsing data for All time.
7. Open https://www.reuters.com/business/environment/us-seeks-double-climate-change-aid-developing-nations-biden-2021-09-21/.

Actual result:

The article is still in Speedreader mode.

Expected result:

I guess the article shouldn't load in Speedreader mode after clearing all browsing data.

If Speedreader is still enabled in settings then the article should still load in Speedreader mode. I don't think clearing browsing data resets that in brave://settings

[Tonev]

Thank you for the clarification, @keur. I thought Speedreader might be using site-specific settings like Brave Shields, and clearing Site and Shields Settings would reset all site-specific Speedreader settings.

I disabled Speedreader via brave://settings/appearance, that disabled the Speedreader mode for the article I mentioned in my previous comment. Enabling Speedreader via brave://settings/appearance reloaded the article in Speedreader mode.

[stephendonner]

Verified PASSED using

Brave	1.38.70 Chromium: 100.0.4896.46 (Official Build) beta (x86_64)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 11.6.5 (Build 20G527)

Followed the steps of my original issue here, from #18234 (comment)

example	example	example	example	example

Confirmed I was able to enable/disable the Speedreader feature correctly from its icon in the URL bar

[MadhaviSeelam]

Verified Passed using

Brave	1.38.78 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision	6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS	Windows 11 Version 21H2 (Build 22000.593)

• Fresh profile
• Launch Brave
• Load https://brave.com/blog/
• Click on the reader-mode icon and click Turn on Speedreader
• Toggle Speedreader on
• Toggle Speedreader off
• Verified turning on and off few times
• Verified Speedreader on/off toggle in the URL bar works expected and the icon do not disappear

ex1	ex2	ex3	ex4