Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields Up Prevents Google Workspace Sign In and Pages From Loading #22112

Closed
x5josh5x opened this issue Apr 6, 2022 · 10 comments
Closed

Shields Up Prevents Google Workspace Sign In and Pages From Loading #22112

x5josh5x opened this issue Apr 6, 2022 · 10 comments
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. google webcompat/shields Shields is breaking a website. workaround/shields-down

Comments

@x5josh5x
Copy link

x5josh5x commented Apr 6, 2022

Description

With Shields Up enabled, unable to sign into Google Workspace. Turning off Shields Up fixes the issue. However, after signing in, if Shields Up is enabled on any page, it will give a error saying 'ERR_TOO_MANY_REDIRECTS'. This is true in a private window, with all extensions disabled as well. There are some pages that will not load, even with Shields Up disabled.

The same doesn't seem to be true with regular Gmail accounts, they seem to be working.

Steps to Reproduce

  1. Turn Shields Up on.
  2. Navigate to drive.google.com and click 'Sign in'.
  3. Attempt to sign in with any Google Workspace account.

Actual result:

This is the page that appears instead:
screenshot

Expected result:

Expected the ability to sign in with Google Workspace accounts.

Reproduces how often:

Easily reproduced every time.

Brave version (info found on brave://version)

Brave: 1.37.111 Chromium: 100.0.4896.79 (Official Build) (arm64)
Revision:( 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS: macOS Version 12.3.1 (Build 21E258)

Version/Channel Information:

  • Can you reproduce this issue with the current release?

Yes. Only attempted on the current release.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?

Yes for some pages, but some pages continue to have issues.

Miscellaneous Information:

Even when Shields Up disabled, some pages aren't loading. For example, Google Workspace Admin help pages won't load at all. Or this page loads and I appeared signed in, but it complains that something went wrong, even with Shields Up disabled:
screenshot2

@rebron
Copy link
Collaborator

rebron commented Apr 7, 2022

cc: @ryanbr

@rebron rebron added feature/shields The overall Shields feature in Brave. workaround/shields-down labels Apr 7, 2022
@rebron rebron added webcompat/shields Shields is breaking a website. google labels Apr 7, 2022
@jekozyra
Copy link

Seconding this issue. I can't log into any site that uses Google SSO.

@ryanbr
Copy link

ryanbr commented Apr 20, 2022

I'll test this under a clean profile, is it reproducible @jekozyra @x5josh5x under a clean Brave profile? If its still an issue, which shield option fixes it (allowing all cookies?)

@x5josh5x
Copy link
Author

@ryanbr Interesting, in the most recent build, I haven't been able to get it to replicate now, under a clean profile, or even my original profile. I've tried with three different profiles and two different Google Workspace accounts, and it all seems to be working even with Shields Up enabled on all Google domains. I'm now on: Version 1.37.116 Chromium: 100.0.4896.127 (Official Build) (arm64)

@ryanbr
Copy link

ryanbr commented Apr 21, 2022

@x5josh5x great to see it resolved, @jekozyra is your similar issue fixed?

@x5josh5x
Copy link
Author

@ryanbr I spoke too soon. I'm still seeing the issue. I'm no sure why it was working for me the other day. But now today, on the same version (Version 1.37.116 Chromium: 100.0.4896.127 (Official Build) (arm64)), I'm getting the same initial issue.

As far as settings go, here is what I have found with my testing:

  1. Opening the Shields Up menu from the browser bar and toggling to 'down' will allow the pages to load:

Screen Shot 2022-04-24 at 11 13 28

  1. If that setting is toggled off, the page won't load again.
  2. If I leave that setting in the 'Shields Up' setting and toggle the cookies settings, there is no change, the pages won't load.
  3. However, by default, I keep 'Trackers & ads blocking' as 'Standard', but if I go into preferences and change it to 'Disabled', the page will load, even in a 'Shields Up' stage:

Screen Shot 2022-04-24 at 11 17 23

  1. Here's the interesting part. Once the page loaded, I think toggled the 'Trackers and ads blocking' setting back to 'Standard' and the page still loaded. Then I tried toggling Shields Up and Shields Down from the browser bar and the pages continued to work.

So it seems like it has something to do with the 'Trackers & ads blocking' setting and if the user temporarily disables the trackers and allows the page to load (seems like @jekozyra is right, watching the URLs going back, it has something to do with the sign-in process), then afterwards, it continues to work, regardless of the trackers setting.

@ryanbr
Copy link

ryanbr commented Apr 28, 2022

Can you check the latest Brave build 1.38.* helps @x5josh5x @jekozyra

@x5josh5x
Copy link
Author

@ryanbr So far, so good! Tested with a few different accounts and even with 'Shields Up' on and 'Trackers & ad blocking' set to 'Standard', was able to sign in and use Google Workspace without issue. Same for SSO, it handled the Google OAuth without issue. I'll keep testing and monitoring and let you know if I find anything, but so far this is promising. Thanks!

@ryanbr
Copy link

ryanbr commented Apr 30, 2022

Is your google now working okay @jekozyra ?

@rebron
Copy link
Collaborator

rebron commented May 20, 2022

Should be fixed starting with 1.38.109 and above. Thanks @x5josh5x for the confirmation.
This issue I believe was a duplicate of #22493

@rebron rebron closed this as completed May 20, 2022
@rebron rebron added the closed/duplicate Issue has already been reported label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. google webcompat/shields Shields is breaking a website. workaround/shields-down
Projects
None yet
Development

No branches or pull requests

4 participants