-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enable 1PES everywhere when global SESSION_ONLY mode is enabled. #13127
Conversation
@@ -105,7 +116,9 @@ bool CookieSettingsBase::ShouldUseEphemeralStorage( | |||
|
|||
bool allow_3p = | |||
IsCookieAccessAllowedImpl(url, site_for_cookies, top_frame_origin); | |||
bool allow_1p = IsFirstPartyAccessAllowed(first_party_url, this); | |||
bool allow_1p = first_party_setting | |||
? IsAllowed(first_party_setting->setting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use already requested value here if it's available. no logic change here.
@mkarolin PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src ++
Reproduced the original issues on
Test Case 1 - Logging into website/Closing Tab
You'll notice you'll be logged out even though you've technically didn't close the browser. Test Case 2 - 404 error via Gmail/Google properties
Verification PASSED on
Test Case 1 - Logging into website/Closing Tab
Test Case 2 - 404 error via Gmail/Google properties
|
Don't enable 1PES when SESSION_ONLY mode is applied via
*, *
content settings patterns.Resolves brave/brave-browser#22493
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: