Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[biobb_chemistry] update 5.0.0 #51435

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[biobb_chemistry] update 5.0.0 #51435

merged 1 commit into from
Oct 16, 2024

Conversation

PauAndrio
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

📝 Walkthrough

Walkthrough

The pull request introduces updates to the meta.yaml file of the biobb_chemistry package. The package version has been incremented from 4.2.1 to 5.0.0, necessitating an update to the SHA256 checksum for the source tarball. The Python version requirement has been raised from >=3.8 to >=3.9. Additionally, the dependencies have been modified: biobb_common is updated from ==4.2.0 to ==5.0.0, ambertools from >=22.0 to >=22.5, and acpype from ==2022.7.21 to >=2023.10.27. These changes are reflected in both the host and run sections of the requirements. The test section remains unchanged, and the about section, which contains metadata about the package, has not been altered.

Possibly related PRs

  • [biobb_common] update 5.0.0 #51335: This PR updates the biobb_common package to version 5.0.0, which is directly related to the main PR as it updates the dependency on biobb_common in the biobb_chemistry package to the same version.
  • [biobb_amber] update 5.0.0 #51430: This PR updates the biobb_amber package to version 5.0.0, which also updates the dependency on biobb_common to 5.0.0, similar to the changes made in the main PR.
  • [biobb_analysis] update 5.0.0 #51431: This PR updates the biobb_analysis package to version 5.0.0, which includes an update to the biobb_common dependency to 5.0.0, aligning with the changes in the main PR.

Suggested labels

please review & merge, new version

Suggested reviewers

  • adamhospital
  • gbayarri

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7546bac and 5ba9091.

📒 Files selected for processing (1)
  • recipes/biobb_chemistry/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (5)
recipes/biobb_chemistry/meta.yaml (5)

10-10: SHA256 checksum updated.

The SHA256 checksum has been updated, which is expected due to the new version of the package. This change helps ensure the integrity of the downloaded package.

To verify the correctness of the new checksum, please run the following command:

#!/bin/bash
# Verify the SHA256 checksum
curl -sL https://pypi.io/packages/source/b/biobb_chemistry/biobb_chemistry-5.0.0.tar.gz | sha256sum

Compare the output with the checksum in the meta.yaml file to ensure they match.


21-21: Python version requirement increased to >=3.9.

The minimum required Python version has been increased from 3.8 to 3.9. This change might affect users who are still using Python 3.8.

Please provide justification for this change. Are there any new features or dependencies that require Python 3.9+? Consider running the following command to check for any mentions of Python version requirements in the package's documentation or changelog:

#!/bin/bash
# Search for mentions of Python version requirements
rg -i "python 3.9|python version|requires python" --type md

Also applies to: 28-28


23-23: biobb_common dependency updated to 5.0.0.

The biobb_common dependency has been updated from 4.2.0 to 5.0.0, which aligns with the major version bump of biobb_chemistry itself.

Please ensure that biobb_chemistry 5.0.0 is fully compatible with biobb_common 5.0.0. Consider running the following command to check for any mentions of biobb_common version requirements or compatibility notes:

#!/bin/bash
# Search for mentions of biobb_common version requirements or compatibility
rg -i "biobb_common.*5.0.0|compatibility.*biobb_common" --type md

Also applies to: 29-29


25-26: Dependencies updated: ambertools and acpype.

The following dependency changes have been made:

  1. ambertools: from >=22.0 to >=22.5
  2. acpype: from ==2022.7.21 to >=2023.10.27

These updates suggest changes to the minimum required versions of these tools. Note that acpype has changed from a fixed version to a minimum version requirement.

Please ensure that biobb_chemistry 5.0.0 is compatible with these new dependency versions. Consider the following:

  1. Test the package with the minimum versions specified (ambertools 22.5 and acpype 2023.10.27).
  2. If possible, test with the latest versions of these dependencies to ensure forward compatibility.
  3. Update the package documentation to reflect these new requirements.

Run the following command to check for any mentions of these dependencies in the package's documentation or changelog:

#!/bin/bash
# Search for mentions of ambertools and acpype version requirements or compatibility
rg -i "ambertools.*22.5|acpype.*2023.10.27|compatibility.*(ambertools|acpype)" --type md

Also applies to: 31-32


2-2: Version bump to 5.0.0 approved.

The package version has been updated from 4.2.1 to 5.0.0, which is a major version bump. This aligns with the PR title and suggests significant changes or potentially breaking updates.

Please ensure that all breaking changes are documented and that users are informed about any necessary migration steps. Consider running the following command to check for any mentions of breaking changes or deprecations in the package's documentation or changelog:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants