Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual resub of Freyja since automatic PR stalled #51539

Closed
wants to merge 2 commits into from

Conversation

joshuailevy
Copy link
Contributor

manual resub of Freyja since automatic PR stalled

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

📝 Walkthrough

Walkthrough

This pull request includes several modifications to the meta.yaml file for the Freyja package. The version number has been updated from "1.5.1" to "1.5.2", and the build number has been adjusted from 1 to 0. The build script has been revised to include additional flags: --no-build-isolation, --no-cache-dir, and -vvv, and it now uses {{ PYTHON }} instead of python. The SHA256 checksum for the source URL has been updated to a new value. In the requirements section, setuptools has been added to the host requirements, while the seaborn dependency has been replaced with seaborn-base. Additionally, sphinx and sphinx_rtd_theme have been added to the run requirements. A new dev_url field has been introduced, linking to the GitHub repository, and overall structural adjustments have been made for consistency.

Possibly related PRs

  • 2024.4 #50977: The changes in the meta.yaml file for the biobb_structure_checking package include a version update and SHA256 checksum modification, similar to the updates made in the meta.yaml file for the Freyja package in the main PR.
  • Update recipe for ViroConstrictor #51038: The meta.yaml file for the ViroConstrictor package has a version increment and SHA256 checksum update, paralleling the changes in the Freyja package's meta.yaml.
  • [biobb_analysis] update 5.0.0 #51431: The biobb_analysis package's meta.yaml file reflects a version update and SHA256 checksum change, akin to the modifications in the Freyja package's meta.yaml.
  • [biobb_chemistry] update 5.0.0 #51435: The biobb_chemistry package's meta.yaml file also shows a version increment and SHA256 checksum update, similar to the changes made in the Freyja package's meta.yaml.
  • [biobb_cp2k] update 5.0.0 #51528: The biobb_cp2k package's meta.yaml file includes a version update and SHA256 checksum modification, which aligns with the updates in the Freyja package's meta.yaml.

Suggested labels

please review & merge

Suggested reviewers

  • adamhospital
  • gbayarri

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6b3870a and a35b973.

📒 Files selected for processing (1)
  • recipes/freyja/meta.yaml (4 hunks)
🧰 Additional context used
🪛 yamllint
recipes/freyja/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (7)
recipes/freyja/meta.yaml (7)

1-1: LGTM: Version update

The package version has been correctly updated to 1.5.2, which is consistent with the PR description.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


9-10: LGTM: Build section updates

The build section has been correctly updated:

  1. Build number reset to 0 for the new version.
  2. Build script improved with best practices for conda builds, including:
    • Using {{ PYTHON }} for version consistency
    • Adding --no-build-isolation and --no-cache-dir for a clean, faster build
    • Increasing verbosity with -vvv for better debugging

25-25: LGTM: Added setuptools to host requirements

Adding setuptools to the host requirements is a good practice. It ensures that the package can be properly built and installed.


59-59: LGTM: Added dev_url

Adding the dev_url pointing to the GitHub repository is a good practice. It provides users with a direct link to the source code and development resources.


1-1: Ignore yamllint error for Jinja2 syntax

The yamllint tool reports a syntax error for the '%' character at the beginning of the file. This is a false positive, as the '%' character is correctly used for Jinja2 templating in conda recipes. The syntax is valid for a conda recipe meta.yaml file.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


44-47: LGTM: Updated run requirements

The run requirements have been updated with the following improvements:

  1. Changed seaborn to seaborn-base, which reduces dependencies and package size.
  2. Added sphinx and sphinx_rtd_theme, suggesting documentation improvements.

These changes align with best practices for conda packages.

To ensure the documentation builds correctly with the new dependencies, you can run:


19-19: Verify SHA256 checksum

The SHA256 checksum has been updated for the new version. Please ensure that this checksum is correct for the source of version 1.5.2.

To verify the checksum, you can run the following command:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joshuailevy
Copy link
Contributor Author

Seems to have been disconnected after 30 minutes or so just like #51511. Any suggestions on how to fix this would be much appreciated!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant