Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mess recipe #51447

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update mess recipe #51447

merged 2 commits into from
Oct 17, 2024

Conversation

farchaab
Copy link
Contributor

PR to update recipe:

  • Bumped minimum python version (to match snakemake's minimal python version)
  • Added apptainer as dependency
  • Removed mamba dependency
  • Bumped rich-click min version

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

📝 Walkthrough

Walkthrough

The pull request introduces several changes to the meta.yaml file for the "MeSS" package. The version number is updated from 0.9.0 to 0.9.1, reflecting an increment in the build number from 0 to 1. The Python version requirement has been modified from >=3.10 to >=3.11 in both the host and run sections. Additionally, a new dependency on apptainer >=1.3.2 has been added to the run section. The existing pandas dependency has been updated from >=2.2.1 to >=2.2.3, and the rich-click dependency has been revised from >=1.7.4 to >=1.8.3. The script and test sections remain unchanged, as does the run_exports section, which continues to pin the mess subpackage. Overall, the structure of the meta.yaml file remains consistent while incorporating these updates.

Possibly related PRs

Suggested labels

please review & merge

Suggested reviewers

  • martin-g
  • gbayarri

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 45f417f and 0ddb359.

📒 Files selected for processing (1)
  • recipes/mess/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (8)
recipes/mess/meta.yaml (8)

13-13: LGTM: Build number increment is appropriate.

The build number has been correctly incremented from 0 to 1. This is the expected practice when updating a package recipe without changing the package version itself.


29-29: LGTM: Python version requirement consistently updated.

The minimum Python version has been correctly updated to 3.11 in the run section, maintaining consistency with the host section.


35-35: LGTM: Pandas version updated.

The Pandas version requirement has been updated from 2.2.1 to 2.2.3.


37-37: LGTM: Rich-click version updated.

The Rich-click version requirement has been updated from 1.7.4 to 1.8.3, which aligns with the PR objectives.


30-30: New dependency added: Apptainer.

A new dependency on Apptainer (version >=1.3.2) has been added. This aligns with the PR objectives.

Let's verify if there are any other occurrences of Apptainer in the file:

#!/bin/bash
# Check for other occurrences of Apptainer
grep -n "apptainer" recipes/mess/meta.yaml

29-37: Verify Mamba dependency removal.

The PR objectives mention removing the Mamba dependency, but this is not visible in the provided diff.

Let's verify if the Mamba dependency has been removed:

#!/bin/bash
# Check for Mamba dependency
grep -n "mamba" recipes/mess/meta.yaml

Line range hint 1-3: Verify package version update.

The AI summary mentions updating the version from 0.9.0 to 0.9.1, but the version in the file is still 0.9.0. This seems inconsistent with the build number increment.

Let's verify if there are any other occurrences of the version number in the file:

#!/bin/bash
# Check for version occurrences
grep -n "0.9." recipes/mess/meta.yaml

24-24: LGTM: Python version requirement updated correctly.

The minimum Python version has been increased from 3.10 to 3.11, which aligns with the PR objectives to match Snakemake's requirements.

Let's verify that this change is consistent in the run section:

✅ Verification successful

Verified: Python version requirement is consistently updated in both host and run sections.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify Python version consistency
grep -n "python >=" recipes/mess/meta.yaml

Length of output: 176


Script:

#!/bin/bash
# Corrected script to verify Python version consistency
grep -n "python >=3\.11" recipes/mess/meta.yaml

Length of output: 95


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@farchaab
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 17, 2024
@martin-g martin-g merged commit 0002406 into bioconda:master Oct 17, 2024
7 checks passed
@farchaab farchaab deleted the mess branch October 24, 2024 08:20
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants