-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matchms dependencies #51552
Update matchms dependencies #51552
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/matchms/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (5)
recipes/matchms/meta.yaml (5)
13-13
: LGTM: Build number increment is correct.Incrementing the build number from 0 to 1 is appropriate when making changes to the package without changing the version. This change follows conda-forge best practices.
25-25
: Verify specific version requirement for 'deprecated' package.The
deprecated
package now requires a minimum version of 1.2.14. Please confirm that this specific version requirement aligns with the upstream project's needs and doesn't introduce any compatibility issues.
30-30
: Verify numpy version range expansion.The
numpy
package requirement has been changed from<1.25
to>1.22,<1.27
. This expands the range of supported numpy versions. Please confirm that this change is intentional and doesn't introduce any compatibility issues with other dependencies or the package itself.
40-40
: Clarify pillow version requirement change.The
pillow
package requirement has changed from=9.5
to!=9.4.0
. This change removes the strict version requirement and only excludes version 9.4.0. Please provide clarification on:
- The reason for excluding specifically version 9.4.0.
- Why the strict version requirement (=9.5) was removed.
- Whether this change aligns with the upstream project's requirements.
25-41
: Verify alignment of dependency updates with upstream project.Several dependencies have been updated with specific version constraints. Please ensure that these changes align with the requirements specified in the upstream project's
pyproject.toml
orsetup.py
file.To verify the dependency versions in the upstream project, you can run:
#!/bin/bash # Check dependency versions in pyproject.toml or setup.py rg -i 'dependencies|install_requires' pyproject.toml setup.py
@BiocondaBot please add label |
Also pinging @hechth and @maximskorik for review. |
Update
matchms
dependencies to match those in the pyproject.toml of the projectPlease read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.