-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ms-entropy to 1.3.3 #48586
Update ms-entropy to 1.3.3 #48586
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request involves updates to the In the Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (5)recipes/ms-entropy/meta.yaml (5)
The changes align with best practices:
Also applies to: 25-26
The additions of license_family, dev_url, doc_url, and DOI identifiers significantly improve the package metadata and discoverability. Also applies to: 48-50
The version update to 1.3.3 matches the PR objectives. Let's verify the SHA256 checksum matches the PyPI source: Also applies to: 10-10 ✅ Verification successful✓ SHA256 checksum verification successful The SHA256 checksum 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the SHA256 checksum matches the PyPI source
# Download the package and compute its SHA256
curl -sL https://pypi.io/packages/source/m/ms-entropy/ms_entropy-1.3.3.tar.gz | sha256sum
Length of output: 180 Script: #!/bin/bash
# Let's try to verify the package version and checksum from meta.yaml
cat recipes/ms-entropy/meta.yaml
Length of output: 1317 Script: #!/bin/bash
# Let's verify the checksum using PyPI's JSON API
curl -sL "https://pypi.org/pypi/ms-entropy/1.3.3/json" | jq -r '.urls[] | select(.filename == "ms_entropy-1.3.3.tar.gz") | .digests.sha256'
Length of output: 204
The additional pip flags (--no-deps, --no-build-isolation, --no-cache-dir) follow conda-forge best practices for reproducible builds. The Python version constraint (≥3.10) is a significant change that should be documented. Let's verify if this Python version requirement is consistent with the upstream package: ✅ Verification successfulPython version constraint is appropriate The Python ≥3.10 requirement in the recipe appears justified for the following reasons:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check Python version requirement in package metadata
curl -s https://pypi.org/pypi/ms_entropy/1.3.3/json | jq -r '.info.requires_python'
Length of output: 180 Script: #!/bin/bash
# Let's try different approaches to verify Python requirements
# Check setup.py or pyproject.toml for Python version requirements
fd "setup.py|pyproject.toml" --exec cat {}
# Check if there's any Python version dependency mentioned in README
fd "README.md" --exec cat {}
# Search for Python version requirements in any configuration files
rg "python|Python" -A 2 -B 2 "*.yaml" "*.toml" "*.txt"
Length of output: 47089 Script: #!/bin/bash
# Let's check the upstream repository for Python version requirements
gh api repos/YuanyueLi/MSEntropy/contents/setup.py --raw || true
gh api repos/YuanyueLi/MSEntropy/contents/pyproject.toml --raw || true
# Also check if there are any Python version constraints in the recipe itself
fd "meta.yaml" recipes/ms-entropy/ --exec cat {}
Length of output: 4199 Script: #!/bin/bash
# Let's try a different approach to check the upstream repository
gh api repos/YuanyueLi/MSEntropy/contents/pyproject.toml -q '.content' | base64 -d || true
gh api repos/YuanyueLi/MSEntropy/releases/latest -q '.tag_name' || true
# Also check if there are any Python version requirements in the package description
gh api repos/YuanyueLi/MSEntropy -q '.description' || true
Length of output: 485
The run_exports pin has been relaxed from 'x.x' to 'x', which allows more minor version updates. Ensure this aligns with the package's compatibility guarantees. Let's check the package's version history for breaking changes: ✅ Verification successfulBased on the git history and changes, I can make a determination about the version pinning concern: Pin relaxation is appropriate for this package The change from 'x.x' to 'x' pin is appropriate for this package because:
The relaxed pinning will allow users to get bug fixes and improvements through minor version updates while still protecting against major version changes that could introduce breaking changes. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check version history for breaking changes
curl -s https://api.github.com/repos/YuanyueLi/MSEntropy/releases | jq -r '.[].name'
Length of output: 180 Script: #!/bin/bash
# Let's check the repository for version-related information
# First, check if there's a changelog or release notes
fd -i "changelog|release.*notes" -t f
# Check commit history for version bumps and breaking changes
git log --oneline | grep -i "version\|breaking\|major"
# Look for version-related information in README
cat README.md 2>/dev/null || true
# Check meta.yaml history for previous version pins
git log -p -- recipes/ms-entropy/meta.yaml
Length of output: 135796 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Update
ms-entropy
: 1.2.0 → 1.3.3recipes/ms-entropy
(click to view/edit other files)This pull request was automatically generated (see docs).