-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[biobb_gromacs] update 5.0.0 #52222
[biobb_gromacs] update 5.0.0 #52222
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/biobb_gromacs/meta.yaml (1)
Line range hint
39-40
: Update license informationThe license_file field is empty but the package uses Apache License 2.0.
Consider adding the path to the LICENSE file:
license: Apache Software License license_family: APACHE - license_file: '' + license_file: LICENSE🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/biobb_gromacs/meta.yaml
(2 hunks)
🔇 Additional comments (4)
recipes/biobb_gromacs/meta.yaml (4)
2-2
: Verify major version bump implications
The update from 4.2.0 to 5.0.0 is a major version change. This suggests potential breaking changes that should be documented.
Please ensure:
- Breaking changes are documented in release notes
- Users are notified about migration steps if any
10-10
: SHA256 checksum update looks correct
The new SHA256 checksum has been provided for the updated version.
Line range hint 16-18
: Review run_exports pinning strategy
The current pinning strategy uses max_pin='x'
which means it will allow patch and minor version updates but block major version updates. This is appropriate for a package following semantic versioning.
21-23
: Review dependency version constraints
Several important dependency updates to note:
- Python requirement increased to >=3.9
- biobb_common pinned to exact version 5.0.0
- gromacs remains at 2022.2
Please confirm:
- The Python version constraint aligns with the package's requirements
- The strict pinning of biobb_common to 5.0.0 is intentional
- No updates are needed for gromacs 2022.2
Also applies to: 26-27
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.