Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annembed to v0.1.5 #51465

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update annembed to v0.1.5 #51465

merged 2 commits into from
Oct 17, 2024

Conversation

jianshu93
Copy link
Contributor

Describe your pull request here

With this new release, we add our own svd algorithm to get rid of ndarray-linalg and also new logo added


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

📝 Walkthrough

Walkthrough

This pull request introduces modifications to the build.sh script and the meta.yaml file for the annembed package. In the build.sh script, the cargo install command has been updated to include a new feature, simdeez_f, alongside the existing intel-mkl-static feature. This change allows the installation of the Rust package with both features while maintaining the overall structure and logic of the script. The meta.yaml file has undergone several updates: the package version has been incremented from 0.1.4 to 0.1.5, the SHA256 checksum has been updated to reflect the new version, and the summary description of the package has been revised to clarify its functionality as a non-linear dimension reduction/embedding algorithm for large-scale biological data.

Possibly related PRs

Suggested labels

autobump, new version

Suggested reviewers

  • mencian

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6a9fb9c and 209a2b1.

📒 Files selected for processing (2)
  • recipes/annembed/build.sh (1 hunks)
  • recipes/annembed/meta.yaml (3 hunks)
🧰 Additional context used
🪛 yamllint
recipes/annembed/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (7)
recipes/annembed/build.sh (2)

Line range hint 1-8: Script structure and purpose are appropriate.

This build script effectively sets up the environment for building the annembed package using Rust/cargo. It includes a workaround for SSH-based Git connections and sets the necessary environment variables. The cargo install command now includes both 'intel-mkl-static' and 'simdeez_f' features, which aligns with the PR objective of updating annembed to v0.1.5 and introducing a new SVD algorithm.

The script structure is sound and serves its purpose well. No further changes are necessary.

🧰 Tools
🪛 Shellcheck

[warning] 5-5: Declare and assign separately to avoid masking return values.

(SC2155)


8-8: LGTM! Verify new feature dependencies.

The addition of the 'simdeez_f' feature to the cargo install command is appropriate and aligns with the PR objective of updating annembed to v0.1.5. This change likely enables the new SVD algorithm mentioned in the PR summary.

To ensure a smooth build process, please verify if the 'simdeez_f' feature introduces any new dependencies or system requirements. You can run the following command to check for any new dependencies in the updated version:

If new dependencies are found, ensure they are properly handled in the meta.yaml file.

✅ Verification successful

Verified! No new dependencies found.

The addition of the simdeez_f feature does not introduce any new dependencies beyond those already present in annembed v0.1.5's Cargo.toml. The feature is managed through the existing hnsw_rs dependency.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for new dependencies in the updated version of annembed

# Fetch the Cargo.toml file
cargo_toml=$(curl -s https://raw.githubusercontent.com/jianshu93/annembed/v0.1.5/Cargo.toml)

# Extract and display dependencies
echo "Dependencies for annembed v0.1.5:"
echo "$cargo_toml" | awk '/^\[dependencies\]/,/^\[/' | grep -v '^\[' | sed 's/^/- /'

# Check for 'simdeez' related dependencies
echo -e "\nChecking for 'simdeez' related dependencies:"
echo "$cargo_toml" | grep -i 'simdeez'

Length of output: 9774

recipes/annembed/meta.yaml (5)

1-1: Version update looks good.

The version has been correctly updated to 0.1.5, which aligns with the PR objective.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


31-31: Summary update enhances clarity.

The addition of "embedding" alongside "dimension reduction" in the summary provides a more comprehensive description of the algorithm's functionality. This change improves the clarity of the package's purpose.


1-1: Ignore yamllint warning about '%' character.

The yamllint tool reported a syntax error for the '%' character at the beginning of the file. This is a false positive as the '%' is part of a valid Jinja2 template syntax, which is commonly used in Conda recipe files. The syntax here is correct and necessary for setting the version variable.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


Line range hint 1-37: Overall, the changes look good and align with the PR objectives.

The updates to the version, SHA256 checksum, and summary description are consistent with the PR's goal of updating annembed to v0.1.5. The changes improve the clarity of the package's purpose and maintain the necessary metadata updates. Once the SHA256 checksum is verified, this file should be ready for merging.


14-14: Verify the updated SHA256 checksum.

The SHA256 checksum has been updated, which is expected with a new version. However, it's crucial to ensure this checksum corresponds to the correct source package for version 0.1.5.

To verify the checksum, you can run the following script:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jianshu93
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 17, 2024
@jianshu93
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 annembed-0.1.5-hdbdd923_0.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
annembed 0.1.5--hdbdd923_0 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/annembed:0.1.5--hdbdd923_0.tar.gz | docker load

@mencian mencian merged commit 30d171e into bioconda:master Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants