Update meta.yaml for spec2vec #49857
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates to the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/spec2vec/meta.yaml (1)
32-32: Remove trailing spaces.There are trailing spaces on this line. These should be removed to maintain clean code.
Apply this change:
- +🧰 Tools
🪛 yamllint
[error] 32-32: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/spec2vec/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/spec2vec/meta.yaml
[error] 32-32: trailing spaces
(trailing-spaces)
🔇 Additional comments (4)
recipes/spec2vec/meta.yaml (4)
38-41: LGTM! Metadata updates improve package information.The changes to the
aboutsection, including the addition of quotes and new fields forlicense_family,dev_url, anddoc_url, improve the package metadata and follow best practices.Also applies to: 43-44
50-51: LGTM! DOI identifier added.The addition of the DOI identifier in the
extrasection is valuable for academic citation and tracking of the package.
25-26: Dependency updates look good, but let's verify the scipy requirement.The updates to
gensimandmatchmsversions are appropriate. However, the addition ofscipy <=1.10.1is noteworthy.Let's verify if this scipy version constraint is necessary:
#!/bin/bash # Description: Check if scipy version constraint is mentioned in the package's setup.py or requirements files. # Search for scipy in setup.py echo "Searching for scipy in setup.py:" rg "scipy" setup.py # Search for scipy in requirements files echo "Searching for scipy in requirements files:" rg "scipy" *requirements*.txt echo "If no results are shown above, the scipy constraint might need further investigation."Also applies to: 30-30
14-17: LGTM! Build script and run_exports updates look good.The changes to the build script and the addition of the
run_exportssection are appropriate. These updates improve build reproducibility and help maintain compatibility.Let's verify if the package version in the recipe matches the latest release:
Update the meta.yaml file for spec2vec to reflect dependency changes.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
New Features
Bug Fixes