-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lsabgc recipe/build to constrain dependency #52197
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)recipes/lsabgc/meta.yaml (3)
Build number increment is correct as we're changing dependency constraints without changing the package version. Line range hint The current ✅ Verification successfulBased on the GitHub API results, I can generate the final response since I have sufficient information about the package's stability history: The current pinning strategy using The release history shows consistent versioning following semantic versioning principles, with changes being well-documented and primarily consisting of:
Additionally, there are no issues labeled with "breaking-change", indicating a stable API. The current 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check for breaking changes in release notes or issues
gh api graphql -f query='
{
repository(owner: "Kalan-Lab", name: "lsaBGC-Pan") {
releases(first: 10) {
nodes {
name
description
tagName
}
}
issues(first: 20, labels: ["breaking-change"]) {
nodes {
title
body
number
}
}
}
}'
Length of output: 5733 🧰 Tools🪛 yamllint[error] 10-10: trailing spaces (trailing-spaces)
The change from Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@BiocondaBot please add label |
Hi, I am the maintainer of this tool, there was an issue with some versions of a dependency so just adding this constraint to prevent issues. |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
|
The recipe should be unchanged from what was previously tested - the constraint just prevents installation of a newer version of a dependency (which had an issue - will loosen this in later versions of lsabgc) - so I think this should be good to go! Thank you in advance! |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.