Update meta.yaml #51802
Update meta.yaml #51802
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces several modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)recipes/resistify/meta.yaml (3)
The build number increment is correct for metadata changes, and the existing
The added
The license has been updated from MIT to GPL-3.0. Let's verify this matches the upstream repository's license. ✅ Verification successfulLicense change to GPL-3.0 is correct and verified The license change from MIT to GPL-3.0 has been verified:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the license in the upstream repository
# Expected: Should find GPL-3.0 license, not MIT
# Get the package version from meta.yaml
version=$(grep 'version = ' recipes/resistify/meta.yaml | cut -d'"' -f2)
# Use GitHub API to check the license
gh api repos/SwiftSeal/resistify/license --jq .license.spdx_id
# Also verify LICENSE file exists in the tagged version
gh api repos/SwiftSeal/resistify/contents/LICENSE?ref=v${version} --jq .type
Length of output: 235 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/resistify/meta.yaml (1)
Line range hint 18-19: Consider broadening Python version support
The package currently only supports Python 3.9. Consider testing with newer Python versions (3.10+) to ensure broader compatibility and longer-term maintenance.
host:
- pip
- - python >=3.9,<3.10
+ - python >=3.9
- hatchling
run:
- - python >=3.9,<3.10
+ - python >=3.9Also applies to: 25-26
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/resistify/meta.yaml (1 hunks)
🔇 Additional comments (3)
recipes/resistify/meta.yaml (3)
51-52: URL changes look good
The addition of dev_url and reformatting of doc_url improve package metadata and follow YAML best practices.
Line range hint 1-55: Package configuration follows Bioconda guidelines
The package is properly configured for Bioconda:
- Appropriate for biological sciences (NLR annotation tool)
- Uses proper pinning with run_exports
- Contains complete metadata
53-55: Verify license change from MIT to GPL-3.0
The license has been updated from MIT to GPL-3.0. Let's verify this matches the upstream repository.
✅ Verification successful
License change to GPL-3.0 is correctly reflected
The upstream repository's LICENSE file confirms that resistify is licensed under GNU General Public License v3.0, matching the license specification in the meta.yaml file.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the license in the upstream repository matches GPL-3.0
# Test: Check if LICENSE file contains GPL-3.0 text
curl -s https://raw.githubusercontent.com/SwiftSeal/resistify/main/LICENSE | grep -i "GNU GENERAL PUBLIC LICENSE"
Length of output: 924
|
@BiocondaBot please add label |
Switched to correct license, added extra info in about section
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.