Add missing elements option to type: list that did not specify
#1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
module
jatorcasso
changed the title
elements option to type: lists that did not specifyelements option to type: list that did not specify
|
recheck |
This was referenced May 5, 2022
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
jatorcasso
added a commit
to jatorcasso/community.aws
that referenced
this pull request
May 6, 2022
…ible-collections#1116) Add missing `elements` option to type: list that did not specify SUMMARY Fixes ansible-collections#1114 ISSUE TYPE Docs Pull Request COMPONENT NAME cloudfront_distribution ecs_taskdefinition elb_application_lb rds_option_group Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit c1d47dd)
This was referenced May 6, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 6, 2022
lambda - fix check mode on creation Depends-On: #1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes #1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2022
lambda - fix check mode on creation Depends-On: #1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes #1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 0bde6bb)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 6, 2022
[PR #1108/0bde6bbd backport][stable-3] lambda - fix check mode on creation This is a backport of PR #1108 as merged into main (0bde6bb). Depends-On: #1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes #1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 7, 2022
execute_lambda - fix check mode and update RETURN docs Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
May 7, 2022
execute_lambda - fix check mode and update RETURN docs Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit f2ad637)
patchback bot
pushed a commit
that referenced
this pull request
May 7, 2022
execute_lambda - fix check mode and update RETURN docs Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit f2ad637)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 9, 2022
rds_instance - add deletion_protection param Depends-On: #1116 SUMMARY Fixes #922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
May 9, 2022
rds_instance - add deletion_protection param Depends-On: #1116 SUMMARY Fixes #922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 77cb097)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 9, 2022
[PR #1115/f2ad6375 backport][stable-3] execute_lambda - fix check mode and update RETURN docs This is a backport of PR #1115 as merged into main (f2ad637). Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 10, 2022
[PR #1115/f2ad6375 backport][stable-2] execute_lambda - fix check mode and update RETURN docs This is a backport of PR #1115 as merged into main (f2ad637). Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Joseph Torcasso <None>
1 task
1 task
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 25, 2022
rds_instance_snapshot - add copy snapshot functionality Depends-On: ansible-collections/amazon.aws#776 Depends-On: #1116 SUMMARY Add support for copying a snapshot Fixes #210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None>
patchback bot
pushed a commit
that referenced
this pull request
May 25, 2022
rds_instance_snapshot - add copy snapshot functionality Depends-On: ansible-collections/amazon.aws#776 Depends-On: #1116 SUMMARY Add support for copying a snapshot Fixes #210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit d04ab42)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 26, 2022
[PR #1078/d04ab427 backport][stable-3] rds_instance_snapshot - add copy snapshot functionality This is a backport of PR #1078 as merged into main (d04ab42). Depends-On: ansible-collections/amazon.aws#776 Depends-On: #1116 SUMMARY Add support for copying a snapshot Fixes #210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
lambda - fix check mode on creation Depends-On: ansible-collections#1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes ansible-collections#1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@0bde6bb
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1115) execute_lambda - fix check mode and update RETURN docs Depends-On: ansible-collections#1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f2ad637
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds_instance - add deletion_protection param Depends-On: ansible-collections#1116 SUMMARY Fixes ansible-collections#922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@77cb097
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ections#1078) rds_instance_snapshot - add copy snapshot functionality Depends-On: ansible-collections/amazon.aws#776 Depends-On: ansible-collections#1116 SUMMARY Add support for copying a snapshot Fixes ansible-collections#210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@d04ab42
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ible-collections#1116) Add missing `elements` option to type: list that did not specify SUMMARY Fixes ansible-collections#1114 ISSUE TYPE Docs Pull Request COMPONENT NAME cloudfront_distribution ecs_taskdefinition elb_application_lb rds_option_group Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@c1d47dd
abikouo
added a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…1095) new modules: lambda_layer and lambda_layer_info SUMMARY The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer ISSUE TYPE New Module Pull Request COMPONENT NAME lambda_layer lambda_layer_info ADDITIONAL INFORMATION Closes: ansible-collections#1116 Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1114
ISSUE TYPE
COMPONENT NAME