-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iam_user - stabilize for migration to amazon.aws #1059
iam_user - stabilize for migration to amazon.aws #1059
Conversation
I tried:
but this didnt work, which is why the manual waiters are there. not sure why I couldnt get that part to work as I expected... EDIT: thanks @alinabuzachis for helping me fix this issue! Had the parentheses wrong |
2f0cc4c
to
3de86fa
Compare
changelogs/fragments/1059-iam_user-add-backoff-logic-handle-errors.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @jatorcasso
I'll leave the PR open to give @tremble or @gravesm an opportunity to re-review if they'd like to
tremble is out for a few weeks, we talked and he said not to block reviews on him
regate |
@jatorcasso This is not going to gate until the failures for the milestone sanity checks are fixed. The new milestone branch just got pushed yesterday (I think?), so there will be a batch of new sanity errors that will have to be dealt with. |
|
regate |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1120 🤖 @patchback |
iam_user - stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws dont delete user login profile on check mode add extra return value user to deprecate iam_user gracefully handle iam_user_info when no users returned ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit a11e66a)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
[PR #1059/a11e66a1 backport][stable-3] iam_user - stabilize for migration to amazon.aws This is a backport of PR #1059 as merged into main (a11e66a). SUMMARY Stabilize for migration to amazon.aws dont delete user login profile on check mode add extra return value user to deprecate iam_user gracefully handle iam_user_info when no users returned ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user Reviewed-by: Alina Buzachis <None>
…#1059) iam_user - stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws dont delete user login profile on check mode add extra return value user to deprecate iam_user gracefully handle iam_user_info when no users returned ISSUE TYPE Feature Pull Request COMPONENT NAME iam_user Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mike Graves <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@a11e66a
…tions#1059) test-requirements.txt: relax the dependency on pytest pytest 6.2.0 is getting old and a recent version should work as expected. Reviewed-by: Mark Chappell <None>
SUMMARY
Stabilize for migration to amazon.aws
user
to deprecateiam_user
iam_user_info
when no users returnedISSUE TYPE
COMPONENT NAME
iam_user