Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam_user - stabilize for migration to amazon.aws #1059

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Apr 12, 2022

SUMMARY

Stabilize for migration to amazon.aws

  • dont delete user login profile on check mode
  • add extra return value user to deprecate iam_user
  • gracefully handle iam_user_info when no users returned
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_user

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Apr 12, 2022
@jatorcasso
Copy link
Contributor Author

jatorcasso commented Apr 12, 2022

I tried:

AWSRetry.jittered_backoff(catch_extra_error_codes=['EntityTemporarilyUnmodifiable'])(
    connection.update_login_profile(**user_params)
)

but this didnt work, which is why the manual waiters are there. not sure why I couldnt get that part to work as I expected...

EDIT: thanks @alinabuzachis for helping me fix this issue! Had the parentheses wrong

@jatorcasso jatorcasso requested a review from jillr April 13, 2022 11:33
@jatorcasso jatorcasso changed the title iam_user - add manual waiters, stabilize for migration to amazon.aws iam_user - add backoff, stabilize for migration to amazon.aws Apr 13, 2022
@jatorcasso jatorcasso requested a review from tremble April 13, 2022 16:59
@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Apr 13, 2022
plugins/modules/iam_user.py Outdated Show resolved Hide resolved
plugins/modules/iam_user.py Outdated Show resolved Hide resolved
@jatorcasso jatorcasso changed the title iam_user - add backoff, stabilize for migration to amazon.aws iam_user - stabilize for migration to amazon.aws Apr 26, 2022
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jatorcasso
I'll leave the PR open to give @tremble or @gravesm an opportunity to re-review if they'd like to

@jillr jillr dismissed tremble’s stale review May 4, 2022 17:04

tremble is out for a few weeks, we talked and he said not to block reviews on him

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label May 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

ansible-galaxy-importer FAILURE in 5m 52s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 15s
ansible-test-sanity-docker-devel FAILURE in 13m 22s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 48s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 12s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 46s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 30s
✔️ ansible-test-splitter SUCCESS in 3m 24s
✔️ integration-community.aws-1 SUCCESS in 6m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor Author

regate

@gravesm
Copy link
Member

gravesm commented May 5, 2022

@jatorcasso This is not going to gate until the failures for the milestone sanity checks are fixed. The new milestone branch just got pushed yesterday (I think?), so there will be a batch of new sanity errors that will have to be dealt with.

@jatorcasso
Copy link
Contributor Author

@jatorcasso This is not going to gate until the failures for the milestone sanity checks are fixed. The new milestone branch just got pushed yesterday (I think?), so there will be a batch of new sanity errors that will have to be dealt with.

@gravesm I made a PR for those here: #1116

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

ansible-galaxy-importer FAILURE in 4m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 24s
ansible-test-sanity-docker-devel FAILURE in 10m 40s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 47s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 21s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 12s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 55s
✔️ integration-community.aws-1 SUCCESS in 7m 47s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor Author

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 51s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 19m 37s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 13m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 59s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 18s
✔️ ansible-test-splitter SUCCESS in 4m 35s
✔️ integration-community.aws-1 SUCCESS in 7m 25s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a11e66a into ansible-collections:main May 5, 2022
@patchback
Copy link

patchback bot commented May 5, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/a11e66a1586b3af7f3c35268c60d419d8b023f33/pr-1059

Backported as #1120

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 5, 2022
iam_user - stabilize for migration to amazon.aws

SUMMARY
Stabilize for migration to amazon.aws

dont delete user login profile on check mode
add extra return value user to deprecate iam_user
gracefully handle iam_user_info when no users returned

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit a11e66a)
@jatorcasso jatorcasso deleted the iam_user/stabilization branch May 5, 2022 22:27
@github-actions
Copy link

github-actions bot commented May 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 6, 2022
[PR #1059/a11e66a1 backport][stable-3] iam_user - stabilize for migration to amazon.aws

This is a backport of PR #1059 as merged into main (a11e66a).
SUMMARY
Stabilize for migration to amazon.aws

dont delete user login profile on check mode
add extra return value user to deprecate iam_user
gracefully handle iam_user_info when no users returned

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1059)

iam_user - stabilize for migration to amazon.aws

SUMMARY
Stabilize for migration to amazon.aws

dont delete user login profile on check mode
add extra return value user to deprecate iam_user
gracefully handle iam_user_info when no users returned

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mike Graves <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@a11e66a
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…tions#1059)

test-requirements.txt: relax the dependency on pytest

pytest 6.2.0 is getting old and a recent version should work as expected.

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants