Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_kms - stabilize integration tests #1112

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented May 2, 2022

SUMMARY

Integration tests for this test suite were failing occasionally due to timing issues when waiting for < 45 seconds after updates.
Increased the wait times to 45 seconds and split into different tests to run in parallel.

Fixes #433

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_kms

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) tests tests labels May 2, 2022
@jatorcasso jatorcasso requested a review from jillr May 2, 2022 22:21
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the docs validation is passing (as we discussed for another PR, a new ansible-core milestone branch was released with new validation parameters, aiui that will be fixed in another PR)

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 20s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 57s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 30s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 24s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 46s
✔️ ansible-test-splitter SUCCESS in 3m 51s
✔️ integration-community.aws-1 SUCCESS in 13m 10s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso jatorcasso closed this May 5, 2022
@jatorcasso jatorcasso reopened this May 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 25s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 28s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 39s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-community.aws-1 SUCCESS in 13m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso jatorcasso added the backport-3 PR should be backported to the stable-3 branch label May 6, 2022
@jatorcasso jatorcasso added the mergeit Merge the PR (SoftwareFactory) label May 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 31s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 06s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 26s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 30s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 13s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 23s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-community.aws-1 SUCCESS in 12m 48s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cda4830 into ansible-collections:main May 7, 2022
@patchback
Copy link

patchback bot commented May 7, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/cda483030be6ac1e40ae8b345bbe700cd6d5dab2/pr-1112

Backported as #1134

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 7, 2022
aws_kms - stabilize integration tests

SUMMARY
Integration tests for this test suite were failing occasionally due to timing issues when waiting for < 45 seconds after updates.
Increased the wait times to 45 seconds and split into different tests to run in parallel.
Fixes #433
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
aws_kms

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit cda4830)
@github-actions
Copy link

github-actions bot commented May 7, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 9, 2022
[PR #1112/cda48303 backport][stable-3] aws_kms - stabilize integration tests

This is a backport of PR #1112 as merged into main (cda4830).
SUMMARY
Integration tests for this test suite were failing occasionally due to timing issues when waiting for < 45 seconds after updates.
Increased the wait times to 45 seconds and split into different tests to run in parallel.
Fixes #433
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
aws_kms

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…nsible-collections#1302)

[6.0.0] s3_object - Remove support for creation/deletion of buckets.

SUMMARY
We previously deprecated support for creation/deletion of buckets using the s3_object module (s3_bucket performs the action much better).  It is slated for removal in 6.0.0
Fixes ansible-collections#1112
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_kms integration tests unstable
4 participants