aws_kms integration tests unstable

[tremble]

SUMMARY

The aws_kms integration tests appear somewhat flaky, this mostly looks like it's due to 'eventual consistency' race conditions, with incorrect 'changed' results, and _info information that seems to be missing the previous change.

aws_kms may need waiters adding.

ISSUE TYPE

• Bug Report

COMPONENT NAME

• aws_kms
• aws_kms_info

ANSIBLE VERSION

CI

CONFIGURATION

CI

OS / ENVIRONMENT

CI

STEPS TO REPRODUCE

Trigger integration test suites

EXPECTED RESULTS

tests consistently pass

ACTUAL RESULTS

Tests sporadically fail with errors like:

 aws_kms-ale83iyr / /root/ansible_collections/community/aws/tests/output/.tmp/integration/aws_kms-9651665y-ÅÑŚÌβŁÈ/tests/integration/targets/aws_kms/tasks/main.yml:333 / [testhost] testhost: aws_kms : assert no change to tags that=['not tag_kms_no_update.changed', "'tag_one' not in tag_kms_no_update.tags", "'tag_two' in tag_kms_no_update.tags", "tag_kms_no_update.tags.tag_two == 'tag_two_updated'", "'Tag Three' in tag_kms_update.tags", "tag_kms_update.tags['Tag Three'] == resource_prefix"]

failure: Assertion failed

{
    "assertion": "not tag_kms_no_update.changed",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

 aws_kms-e8bbn_js / /root/ansible_collections/community/aws/tests/output/.tmp/integration/aws_kms-_xr85pv6-ÅÑŚÌβŁÈ/tests/integration/targets/aws_kms/tasks/main.yml:65 / [testhost] testhost: aws_kms : assert that state is enabled that=['"key_id" in create_kms', 'create_kms.key_id | length >= 36', 'not create_kms.key_id.startswith("arn:aws")', '"key_arn" in create_kms', 'create_kms.key_arn.endswith(create_kms.key_id)', 'create_kms.key_arn.startswith("arn:aws")', 'create_kms.key_state == "Enabled"', "create_kms.tags['Hello'] == 'World'", 'create_kms.enable_key_rotation == false']

failure: Assertion failed

{
    "assertion": "create_kms.enable_key_rotation == false",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

[ansibullbot]

Files identified in the description:

• plugins/modules/aws_kms.py
• plugins/modules/aws_kms_info.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @s-hertel @willthames @wimnat
click here for bot help

[ansibullbot]

cc @markuman
click here for bot help

[jatorcasso]

@tremble I tried adding some manual waiters for tag updates, policy updates, etc, but still ran into testing failures. Im not sure what else to do aside from just sleeping after updates.. (PR is #1052)