[PR #1115/f2ad6375 backport][stable-3] execute_lambda - fix check mode and update RETURN docs #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
execute_lambda - fix check mode and update RETURN docs Depends-On: #1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit f2ad637)
ansibullbot
added
bug
alinabuzachis
approved these changes
May 9, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/f2ad6375ad5ff0d07158f7b8248968b1d5e08966/pr-1115
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ble_policy slightly (ansible-collections#1136) Improve unit test coverage of module_utils.policy SUMMARY Improve unit test coverage of module_utils.policy Slight refactor of _hashable_policy to reduce complexity (and make testing easier) Deprecates sort_json_policy_dict, it's very naive and was only used by ecs_ecr ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/policy.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1115 as merged into main (f2ad637).
Depends-On: #1116
SUMMARY
name,function_arnISSUE TYPE
COMPONENT NAME
execute_lambda
ADDITIONAL INFORMATION
I noticed some modules in community.aws will return data directly, and others will return data nested in a dict.
Example: let iam_group be the module, retrieving a key called
group_arn, and registering the response asresponse. Some modules you would need to queryresult.iam_group.group_arn, meanwhile in others, you canresult.group_arn(where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward?