Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lambda KMSKeyArn #1111

Closed
1 task done
sethernet opened this issue May 2, 2022 · 3 comments · Fixed by #1108
Closed
1 task done

Add support for lambda KMSKeyArn #1111

sethernet opened this issue May 2, 2022 · 3 comments · Fixed by #1108
Assignees
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@sethernet
Copy link

Summary

Please add support to set KMSKeyArn when creating and updating lambda functions.

https://docs.aws.amazon.com/lambda/latest/dg/API_CreateFunction.html#SSS-CreateFunction-request-KMSKeyArn
https://docs.aws.amazon.com/lambda/latest/dg/API_UpdateFunctionCode.html#SSS-UpdateFunctionCode-response-KMSKeyArn

Issue Type

Feature Idea

Component Name

lambda

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels May 2, 2022
@jatorcasso jatorcasso self-assigned this May 2, 2022
@jatorcasso
Copy link
Contributor

@sethernet thanks for this request - added it as part of #1108. Let me know if that works!

softwarefactory-project-zuul bot pushed a commit that referenced this issue May 6, 2022
lambda - fix check mode on creation

Depends-On: #1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes #1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
patchback bot pushed a commit that referenced this issue May 6, 2022
lambda - fix check mode on creation

Depends-On: #1116
SUMMARY

When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".

Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.

Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.

Fixes #1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 0bde6bb)
softwarefactory-project-zuul bot pushed a commit that referenced this issue May 6, 2022
[PR #1108/0bde6bbd backport][stable-3] lambda - fix check mode on creation

This is a backport of PR #1108 as merged into main (0bde6bb).
Depends-On: #1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes #1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY

When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".

Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.

Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.

Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0bde6bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants