Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1078/d04ab427 backport][stable-3] rds_instance_snapshot - add copy snapshot functionality #1156

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 25, 2022

This is a backport of PR #1078 as merged into main (d04ab42).

Depends-On: ansible-collections/amazon.aws#776
Depends-On: #1116

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance_snapshot

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections/amazon.aws#776
Depends-On: #1116
SUMMARY

Add support for copying a snapshot
Fixes #210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit d04ab42)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 22s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 41s
ansible-test-sanity-docker-devel RETRY_LIMIT in 5m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 30s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 53s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 53s
✔️ ansible-test-splitter SUCCESS in 2m 23s
integration-community.aws-1 FAILURE in 24m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
ansible-test-sanity-docker-devel RETRY_LIMIT in 6m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 12s
ansible-test-sanity-docker-stable-2.11 POST_FAILURE in 11m 47s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 03s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 38s
✔️ ansible-test-splitter SUCCESS in 2m 21s
integration-community.aws-1 FAILURE in 27m 41s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor

requires ansible-collections/amazon.aws#839 (I think? Assuming community.aws stable-3 runs integration tests with amazon.aws stable-3)

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 50s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 27s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 45s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 06s
✔️ ansible-test-splitter SUCCESS in 2m 22s
✔️ integration-community.aws-1 SUCCESS in 23m 16s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 13s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 58s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 26s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 35s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 31s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 24m 10s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 91cbf14 into stable-3 May 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/d04ab42766f82d928440db9c84dfb9bb23039326/pr-1078 branch May 26, 2022 08:38
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…tions#1156)

dev_guidelines: initiate a paragraph about unit-tests

Add some basic information regarding the unit-testing and initiate a list
guidelines. More will come later.

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants