Backport stable-3 - rds module_util - add retry_code to get_rds_method_attributes and add… #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality for copying snapshot (ansible-collections#776) rds module_util - add retry_code to get_rds_method_attributes and add functionality for copying snapshot SUMMARY catch InvalidDBSecurityGroupStateFault when modifying db add retry_codes to return data from get_rds_method_attribute, and add unit tests to cover add functionality for copy_db_snapshot refactor to utilize the return values of get_rds_method_attribute ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME rds ADDITIONAL INFORMATION Ran into the InvalidDBSecurityGroupStateFault error running integration tests for community.aws.rds_instance There is quite a bit of refactoring here so I wanted to explain why I made the changes I did: there were many instances of calling get_rds_method_attribute to retrieve certain values (waiter, retry_codes, which RDS resource), so I tried to remove the duplicate calls and use the return values already retrieved from the initial call. split wait_for_snapshot_status into wait_for_instance_snapshot_status and wait_for_cluster_snapshot_status, as they have different identifiers (they are also broken up in get_final_identifier) The initial goal here was simply to add retry_codes as a return value of get_rds_method_attribute and add copy_db_snapshot as a valid method, but working through that uncovered some bugs and just general redundancies, so I felt these were necessary changes. Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Sloane Hertel <None> (cherry picked from commit b002515)
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
May 25, 2022
jillr
approved these changes
May 25, 2022
softwarefactory-project-zuul
bot
merged commit 31776d9
into
ansible-collections:stable-3
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Manual backport of #776
ISSUE TYPE
COMPONENT NAME
rds