Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_instance_snapshot - add copy snapshot functionality #1078

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Apr 19, 2022

Depends-On: ansible-collections/amazon.aws#776
Depends-On: #1116

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance_snapshot

@jatorcasso jatorcasso force-pushed the rds_instance_snapshot/check-mode-integration-tests branch from 15bd533 to c5acb60 Compare April 19, 2022 20:56
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Apr 19, 2022
@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@jatorcasso
Copy link
Contributor Author

recheck

@jatorcasso jatorcasso marked this pull request as draft April 28, 2022 00:22
@jatorcasso jatorcasso marked this pull request as ready for review April 28, 2022 18:20
@jatorcasso jatorcasso changed the title rds_instance_snapshot - add check_mode support and integration tests rds_instance_snapshot - add check_mode support and copy snapshot Apr 29, 2022
@gravesm
Copy link
Member

gravesm commented May 6, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 34s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 11s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 50s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 11s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 57s
✔️ ansible-test-splitter SUCCESS in 3m 04s
✔️ integration-community.aws-1 SUCCESS in 20m 30s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label May 6, 2022
@jatorcasso jatorcasso requested a review from markuman May 6, 2022 21:16
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 10, 2022
@jatorcasso jatorcasso changed the title rds_instance_snapshot - add check_mode support and copy snapshot rds_instance_snapshot - add copy snapshot functionality May 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 6m 07s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 18s
ansible-test-sanity-docker-devel FAILURE in 11m 43s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 41s
ansible-test-sanity-docker-stable-2.9 FAILURE in 14m 15s
ansible-test-sanity-docker-stable-2.11 FAILURE in 16m 58s
ansible-test-sanity-docker-stable-2.12 FAILURE in 12m 04s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 58s
✔️ ansible-test-splitter SUCCESS in 7m 25s
✔️ integration-community.aws-1 SUCCESS in 26m 39s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso jatorcasso force-pushed the rds_instance_snapshot/check-mode-integration-tests branch from f0c3b67 to 69de83e Compare May 10, 2022 01:18
@jatorcasso jatorcasso marked this pull request as ready for review May 10, 2022 01:22
@jatorcasso jatorcasso requested a review from markuman May 10, 2022 01:23
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 05s
ansible-test-sanity-docker-stable-2.9 FAILURE in 14m 00s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 50s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 30s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-community.aws-1 SUCCESS in 22m 04s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 34s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 50s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 16m 12s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 02s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 00s
✔️ ansible-test-splitter SUCCESS in 2m 58s
✔️ integration-community.aws-1 SUCCESS in 22m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 7m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 32s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 33s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 48s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 30s
✔️ ansible-test-splitter SUCCESS in 2m 52s
✔️ integration-community.aws-1 SUCCESS in 21m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@alinabuzachis
Copy link
Contributor

@jatorcasso Will take a look at this again ansible-collections/amazon.aws#776 tomorrow!

@jatorcasso jatorcasso requested a review from s-hertel May 24, 2022 00:10
@jatorcasso
Copy link
Contributor Author

@alinabuzachis @markuman do we want this in 3.3.0 as well?

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 46s
ansible-test-sanity-docker-devel RETRY_LIMIT in 6m 37s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 07s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 00s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 04s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 58s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 26s
✔️ integration-community.aws-1 SUCCESS in 23m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d04ab42 into ansible-collections:main May 25, 2022
@patchback
Copy link

patchback bot commented May 25, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/d04ab42766f82d928440db9c84dfb9bb23039326/pr-1078

Backported as #1156

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 25, 2022
rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections/amazon.aws#776
Depends-On: #1116
SUMMARY

Add support for copying a snapshot
Fixes #210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit d04ab42)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 26, 2022
[PR #1078/d04ab427 backport][stable-3] rds_instance_snapshot - add copy snapshot functionality

This is a backport of PR #1078 as merged into main (d04ab42).
Depends-On: ansible-collections/amazon.aws#776
Depends-On: #1116
SUMMARY

Add support for copying a snapshot
Fixes #210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ections#1078)

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections/amazon.aws#776
Depends-On: ansible-collections#1116
SUMMARY

Add support for copying a snapshot
Fixes ansible-collections#210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@d04ab42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend rds module to allow copying of rds snaphots cross region
5 participants