feat: Expose block selector config from rrweb to SR plugin/SDK. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
* fix: allow optionally starting new session on setUserId * fix: update setUserId(id, startNewSession) always start new session if requested * fix: update web-client to allow for `startNewSession` * chore: update session integration tests * chore: test fix * chore: revert interface changes * chore: revert interface changes in tests * chore: update tests for new session change logic * chore: fix set user test
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
* feat: log response body from API to logger
* fix: fix test for 429 status, extend 'log unexpected error' test to increase coverage
* fix: add status code to response logging
* chore: typo
* fix: reject send errors
* chore: resolve promise for req.on('error'), remove throw error from SDK
* chore: remove superfluous logging on success
* chore: only log intermediate responses prior to retry
* chore: remove duplicate logging on "other": response
* chore: clean up test logic
---------
Co-authored-by: Andrey Sokolov <[email protected]>
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
* feat: added extendSession() method to Browser Client * fix: implement extendSession() method for RN Client and Browser Client factory * chore: code clean up * chore: fix mocks * chore: handle deferred config * chore: fix comment in test * chore: add snippet proxy test for extendSession()
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
* fix: do not fetch advertising Id if adid tracking is disabled * fix: ios compilation
- @amplitude/[email protected]
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
* feat: make auto-tracking solely use css selector allowlist * feat: add default allowlist class * docs: update readme
- @amplitude/[email protected]
- @amplitude/[email protected]
- @amplitude/[email protected]
- @amplitude/[email protected]
* feat: add default data attr selector * refactor: adjust the order of data attr to be ahead of the class
- @amplitude/[email protected]
…r properties to plugin
- @amplitude/[email protected] - @amplitude/[email protected]
* fix: skip parent element event when it is not target * feat: limit to only the innermost allowed element
- @amplitude/[email protected]
- @amplitude/[email protected] - @amplitude/[email protected]
- @amplitude/[email protected] - @amplitude/[email protected]
* feat: integrate with selector * refactor: better naming and using constant
- @amplitude/[email protected] - @amplitude/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the block selector from rrweb to support ebay's case of blocking based on selector.
Checklist
no