Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fetch advertising Id if adid tracking is disabled #424

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

falconandy
Copy link
Contributor

Summary

Based on amplitude/Amplitude-Kotlin#125

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @falconandy. LGTM.

@justin-fiedler justin-fiedler merged commit 52f7b08 into v1.x Jun 13, 2023
@justin-fiedler justin-fiedler deleted the AMP-76882-disable-adid-not-working branch June 13, 2023 16:39
falconandy added a commit that referenced this pull request Jun 27, 2023
* fix: do not fetch advertising Id if adid tracking is disabled

* fix: ios compilation
justin-fiedler pushed a commit that referenced this pull request Jun 29, 2023
* fix: do not fetch advertising Id if adid tracking is disabled (#424)

* fix: do not fetch advertising Id if adid tracking is disabled

* fix: ios compilation

* fix: add app_set_id, idfa and idfv support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants