Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate with selector #620

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: integrate with selector #620

merged 2 commits into from
Nov 16, 2023

Conversation

liuyang1520
Copy link
Contributor

@liuyang1520 liuyang1520 commented Nov 10, 2023 •
edited
Loading

Summary

feat: integrate with selector

  • Add the lazy loading of visual tagging selector UI when enabled
  • Implement a messenger to sync to the opener, treating the selector UI as a tool to only get the selected element

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@liuyang1520 liuyang1520 requested review from justin-fiedler and a team November 10, 2023 22:05
@liuyang1520 liuyang1520 marked this pull request as ready for review November 10, 2023 22:05
justin-fiedler
justin-fiedler approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @liuyang1520!

packages/plugin-default-event-tracking-advanced-browser/src/helpers.ts Outdated Show resolved Hide resolved
packages/plugin-default-event-tracking-advanced-browser/src/helpers.ts Outdated Show resolved Hide resolved
packages/plugin-default-event-tracking-advanced-browser/src/libs/messenger.ts Outdated Show resolved Hide resolved
packages/plugin-default-event-tracking-advanced-browser/src/libs/messenger.ts Outdated Show resolved Hide resolved
packages/plugin-default-event-tracking-advanced-browser/src/libs/messenger.ts Outdated Show resolved Hide resolved
@liuyang1520 liuyang1520 force-pushed the load-visual-tagging-selector branch from 15a66e3 to 12315c7 Compare November 16, 2023 20:37
@liuyang1520 liuyang1520 merged commit 7afb5c7 into v1.x Nov 16, 2023
3 checks passed
@liuyang1520 liuyang1520 deleted the load-visual-tagging-selector branch November 16, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyang1520 @justin-fiedler