Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove event stopPropagation #608

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: remove event stopPropagation #608

merged 1 commit into from
Oct 27, 2023

Conversation

liuyang1520
Copy link
Contributor

Summary

  • fix: remove event stopPropagation

I was under the wrong impression that stopPropagation won't affect the parent clicking event when there are other onclick attached, this fix removes the stopPropagation.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@liuyang1520 liuyang1520 merged commit afe1cc2 into v1.x Oct 27, 2023
3 checks passed
@liuyang1520 liuyang1520 deleted the fix-event-propagation branch October 27, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpagtakhan kevinpagtakhan kevinpagtakhan approved these changes

@justin-fiedler justin-fiedler Awaiting requested review from justin-fiedler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyang1520 @kevinpagtakhan