feat: added extendSession() method to Browser Client #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercy811
approved these changes
Jun 12, 2023
yuhao900914
approved these changes
Jun 12, 2023
justin-fiedler
deleted the
AMP-77777-add-extend-session-method-to-browser-sdk
branch
|
we should also update the snippet loader to include the new public facing method |
kevinpagtakhan
pushed a commit
that referenced
this pull request
Jun 14, 2023
* feat: added extendSession() method to Browser Client * fix: implement extendSession() method for RN Client and Browser Client factory * chore: code clean up * chore: fix mocks * chore: handle deferred config * chore: fix comment in test * chore: add snippet proxy test for extendSession()
1 task
kevinpagtakhan
added a commit
that referenced
this pull request
Jun 14, 2023
Co-authored-by: Justin Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
** Add extendSession() method to Browser SDK to allow customers to extend the current session without sending events / using quota.
Checklist