Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(session replay): remove recording terms #618

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat(session replay): remove recording terms #618

merged 1 commit into from
Nov 10, 2023

Conversation

jxiwang
Copy link

@jxiwang jxiwang commented Nov 10, 2023

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@jxiwang jxiwang marked this pull request as ready for review November 10, 2023 00:28
jackson-amplitude
jackson-amplitude approved these changes Nov 10, 2023
View reviewed changes
Copy link

@jackson-amplitude jackson-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love the red =)

@jxiwang jxiwang merged commit 01ef397 into v1.x Nov 10, 2023
4 of 5 checks passed
@jxiwang jxiwang deleted the AMP-87714 branch November 10, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackson-amplitude jackson-amplitude jackson-amplitude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxiwang @jackson-amplitude