Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types for plugins to be env specific #440

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: types for plugins to be env specific #440

merged 1 commit into from
Jun 16, 2023

Conversation

kevinpagtakhan
Copy link
Collaborator

@kevinpagtakhan kevinpagtakhan commented Jun 16, 2023 •
edited
Loading

Summary

  • Type hints for amplitude.add() shows core interface instead of env specific interface both for config and client parameters

Before:
config
Screenshot 2023-06-16 at 12 46 24 PM

client
Screenshot 2023-06-16 at 12 50 33 PM

After:
config
Screenshot 2023-06-16 at 12 44 01 PM

client
Screenshot 2023-06-16 at 12 51 50 PM

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@kevinpagtakhan kevinpagtakhan requested review from a team June 16, 2023 19:49
@kevinpagtakhan kevinpagtakhan self-assigned this Jun 16, 2023
@kevinpagtakhan kevinpagtakhan marked this pull request as ready for review June 16, 2023 19:50
@kevinpagtakhan kevinpagtakhan merged commit 46b297c into main Jun 16, 2023
@kevinpagtakhan kevinpagtakhan deleted the AMP-78349 branch June 16, 2023 20:34
kevinpagtakhan added a commit that referenced this pull request Jun 16, 2023
@kevinpagtakhan
fix: types for plugins to be env specific (#440)
8584efe
@kevinpagtakhan kevinpagtakhan mentioned this pull request Jun 16, 2023
Merged
1 task
kevinpagtakhan added a commit that referenced this pull request Jun 16, 2023
@kevinpagtakhan
fix: types for plugins to be env specific (#440) (#441)
b31226d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@yuhao900914 yuhao900914 yuhao900914 approved these changes

Assignees

@kevinpagtakhan kevinpagtakhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinpagtakhan @yuhao900914 @qingzhuozhen